Fix #2481, correct loop variable #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CMake loop is supposed to run for every app. Unfortunately at this point the SYSVAR is not yet defined, so the result is it does nothing and none of the overrides get configured. With this loop, it should set up the override directive correctly.
jphickey
added
the
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
This CMake loop is supposed to run for every app. Unfortunately at this point the SYSVAR is not yet defined, so the result is it does nothing and none of the overrides get configured.
With this loop, it should set up the override directive correctly.
Fixes #2481
Testing performed
Build with override msgids.h file
Expected behavior changes
Global msgids.h will be used by every app
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.