Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mission-wide "msgids.h" header not getting properly wrapped in apps #2481

Closed
jphickey opened this issue Dec 13, 2023 · 0 comments · Fixed by #2482
Closed

Mission-wide "msgids.h" header not getting properly wrapped in apps #2481

jphickey opened this issue Dec 13, 2023 · 0 comments · Fixed by #2482
Assignees
@jphickey

Comments

@jphickey
Copy link
Contributor

Describe the bug
When trying to point to a global msgids.h file (e.g. a cfs_msgids.h that has every app msgid in it) the wrappers are not getting properly generated.

To Reproduce
Define a global msgids.h file and build CFE. The generated wrapper still uses the default msgids.h file.

Expected behavior
Should pick up the global file, not the default file.

Code snips
Issue is that this code was moved late in testing, and as a result this loop is using a list that's always empty:

cFE/cmake/arch_build.cmake

Lines 669 to 673 in 70458a2

foreach(DEP_NAME ${TGTSYS_${SYSVAR}_APPS} ${TGTSYS_${SYSVAR}_STATICAPPS})
string(TOUPPER "${DEP_NAME}_CFGFILE_SRC" CFGSRC)
list(APPEND OUTPUT_VAR_LIST ${CFGSRC}_${DEP_NAME}_msgids)
endforeach(DEP_NAME ${MISSION_APPS})

System observed on:
Debian

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Dec 13, 2023
jphickey added a commit to jphickey/cFE that referenced this issue Dec 13, 2023
@jphickey
Fix nasa#2481, correct loop variable
2c22190 
This CMake loop is supposed to run for every app.  Unfortunately at
this point the SYSVAR is not yet defined, so the result is it does
nothing and none of the overrides get configured.

With this loop, it should set up the override directive correctly.
@jphickey jphickey mentioned this issue Dec 13, 2023
Merged
2 tasks
dmknutsen added a commit that referenced this issue Dec 15, 2023
@dmknutsen
Merge pull request #2482 from jphickey/fix-2481-msgids
7f5ebcd 
Fix #2481, correct loop variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2481, correct loop variable jphickey/cFE
1 participant
@jphickey