Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix #2395, do not directly use cfe_test_msgids.h" #2404

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Revert "Fix #2395, do not directly use cfe_test_msgids.h" #2404

merged 1 commit into from
Jul 17, 2023

Conversation

jphickey
Copy link
Contributor

Reverts #2399

@dzbaker dzbaker linked an issue Jul 17, 2023 that may be closed by this pull request
Testcase code should not directly include "cfe_test_msgids.h" (yet) #2395
Closed
@dzbaker dzbaker added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) CCB:FastTrack labels Jul 17, 2023
@skliper
Copy link
Contributor

skliper commented Jul 17, 2023

@jphickey - why is this being reverted? This fixed an issue for us.

@jphickey
Copy link
Contributor Author

Turns out, this only works if you have cfe_testcase included in the application set. If you don't build the testcase app, it breaks the build ..... see https://github.com/nasa/cFS/actions/runs/5579990936/jobs/10196292874

@dzbaker dzbaker merged commit a8b20ac into main Jul 17, 2023
36 of 37 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Jul 17, 2023
@dzbaker
Merge pull request #686 from nasa/integration-candidate
8572ad0 
Fast-Tracked cFE Pull Request nasa/cFE#2398, nasa/cFE#2399, nasa/cFE#2404: Resolves nasa/cFE#2393, nasa/cFE#2395. Reverts nasa/cFE#2399
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) CCB:FastTrack labels Jul 20, 2023
@dmknutsen dmknutsen added this to the Equuleus milestone Aug 3, 2023
@skliper skliper mentioned this pull request Sep 1, 2023
Closed
@jphickey jphickey deleted the revert-2399-fix-2395-cfe-test-msgid branch January 16, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging this pull request may close these issues.

Testcase code should not directly include "cfe_test_msgids.h" (yet)
4 participants
@jphickey @skliper @dzbaker @dmknutsen