Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast-Tracked cFE Pull Request nasa/cFE#2398, nasa/cFE#2399, nasa/cFE#2404: Resolves nasa/cFE#2393, nasa/cFE#2395. Reverts nasa/cFE#2399 #686

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

dzbaker
Copy link
Contributor

@dzbaker dzbaker commented Jul 17, 2023

Checklist (Please check before submitting)

Describe the contribution
Setting this value to 0 allows it to get the same result regardless of the setting of CFE_MISSION_TIME_CFG_DEFAULT_UTC.
For a user that has customized cfe_msgids.h, this will get conflicting values. If/when users have migrated to module-specific msgid files, this will be OK, but for now this can break things.

Fixes nasa/cFE#2393, nasa/cFE#2395

Testing performed
Build with CFE_MISSION_TIME_CFG_DEFAULT_UTC == true
Build using override of cfe_msgids.h (only).

Expected behavior changes
Build and test succeeds
No conflicting msgids if user has overridden cfe_msgids.h but not cfe_test_msgids.h

System(s) tested on
Debian

Contributor Info - All information REQUIRED for consideration of pull request
@jphickey

@dzbaker dzbaker changed the title Fast-Tracked cFE Pull Request cFE#2398: Resolves cFE#2393. Fast-Tracked cFE Pull Request nasa/cFE#2398, nasa/cFE#2399: Resolves nasa/cFE#2393, nasa/cFE#2395. Jul 17, 2023
…ed cFE Pull Request cFE#2399: Resolves cFE#2395. Fast-Tracked cFE Pull Request cFE#2404: Reverts cFE#2395.
@dzbaker dzbaker changed the title Fast-Tracked cFE Pull Request nasa/cFE#2398, nasa/cFE#2399: Resolves nasa/cFE#2393, nasa/cFE#2395. Fast-Tracked cFE Pull Request nasa/cFE#2398, nasa/cFE#2399, nasa/cFE#2404: Resolves nasa/cFE#2393, nasa/cFE#2395. Reverts nasa/cFE#2399 Jul 17, 2023
@dzbaker dzbaker merged commit 8572ad0 into main Jul 17, 2023
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFE TIME coverage test fails if set to use UTC
1 participant