Fix #2128, use correct loop var in add_cfe_app_dependency #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was not using the loop variable, so ended up adding only the first item.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Jul 29, 2022
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 4, 2022
*Combines:* cfe v7.0.0-rc4+dev157 osal v6.0.0-rc4+dev103 *Includes* - nasa/cFE#2129, use correct loop var in add_cfe_app_dependency - nasa/cFE#2117, Automatic suppression of flooding events - nasa/cFE#2126, Remove stray TODO in UT - nasa/osal#1274, Remove stray terminators - nasa/osal#1276, Add RTEMS timebase callback wrapper Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Jose Martinez Pedraza <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 4, 2022
*Combines:* cfe v7.0.0-rc4+dev157 osal v6.0.0-rc4+dev103 *Includes* - nasa/cFE#2129, use correct loop var in add_cfe_app_dependency - nasa/cFE#2117, Automatic suppression of flooding events - nasa/cFE#2126, Remove stray TODO in UT - nasa/osal#1274, Remove stray terminators - nasa/osal#1276, Add RTEMS timebase callback wrapper Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Jose Martinez Pedraza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
This function was not using the loop variable, so ended up adding only the first item.
Fixes #2128
Testing performed
Call add_cfe_app_dependency with multiple items
Expected behavior changes
All dependency items get registered, and compilation gets full API include paths, not just the first one.
System(s) tested on
Ubuntu 22.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.