Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only the first item passed to add_cfe_app_dependency() function is actually registered #2128

Closed
jphickey opened this issue Jul 29, 2022 · 0 comments · Fixed by #2129 or #2130
Closed
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

Describe the bug
The add_cfe_app_dependency() function in the build system is intended to register when one module depends on another module. It is supposed to accept a list of modules, but only the first item actually gets registered. If attempting to register more than one, the second item (and anything beyond that) do not have an effect.

To Reproduce
Attempting to change the "BP" app to depend on the bplib library as well as a input/output layer called "iodriver", I changed:

add_cfe_app_dependency(bp bplib)
to
add_cfe_app_dependency(bp bplib iodriver)

However this did not have any effect, I did not get the iodriver public include path as expected - it did nothing.

Expected behavior
All listed dependencies should be registered and public include paths of all dependencies should be added to the app target.

System observed on:
Ubuntu 22.04

Additional context
This is caused by the wrong variable in the loop. There is a loop to handle all the listed dependencies, but it registers the first one multiple times, because the wrong variable is referenced inside the loop.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Jul 29, 2022
@jphickey jphickey added the bug label Jul 29, 2022
jphickey added a commit to jphickey/cFE that referenced this issue Jul 29, 2022
This function was not using the loop variable, so ended up adding
only the first item.
@skliper skliper added this to the Draco milestone Jul 29, 2022
dzbaker added a commit that referenced this issue Aug 4, 2022
Fix #2128, use correct loop var in add_cfe_app_dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants