Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1141, pipe name unset #1142

Merged

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Jan 29, 2021

Describe the contribution
Fix #1141 Only print the Pipe ID in the debug event

Testing performed
Enable debug events and run CFE, observe events

Expected behavior changes
Debug subscription events have pipe ID, no name.

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added CCB:FastTrack CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 29, 2021
@jphickey
Copy link
Contributor Author

Suggesting fast track here, as this fixes an issue in "main" when one enables debug events.

Do not print the pipe name in the debug event, just pipe ID.
@jphickey
Copy link
Contributor Author

Correction - the original idea of just getting the pipe name broke many unit tests because there is (strangely) a debug event for getting a pipe name, and all unit test event counts became wrong again. Simpler and better fix to just not print the name, only ID.

We should also remove the debug event on CFE_SB_GetPipeName success. This generates a large number of clutter events, and makes UT fragile, and none of the other "get name" APIs have an event on success.

@astrogeco astrogeco changed the base branch from main to integration-candidate February 3, 2021 03:04
@astrogeco astrogeco merged commit 7d311a7 into nasa:integration-candidate Feb 3, 2021
@astrogeco astrogeco added CCB:2021-02-02 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Feb 3, 2021
@jphickey jphickey deleted the fix-1141-fixup-debug-event branch March 10, 2021 14:43
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"PipeName" is unset for debug event
3 participants