Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1032, Send->Write name update for SB write cmds #1118

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Fix #1032, Send->Write name update for SB write cmds #1118

merged 1 commit into from
Jan 27, 2021

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 22, 2021

Describe the contribution
Fix #1032 - updated "Send" to "Write" in command names that write files. Includes function names, command code names and comments.

Testing performed
Standard build and run unit tests, passed. Made user's guide w/ no errors/warnings.

Expected behavior changes
None, name change to fix misnomer

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
Additional update pending #1102 merge

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 22, 2021
@skliper skliper added this to the 7.0.0 milestone Jan 22, 2021
@astrogeco astrogeco added CCB:2021-01-27 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 27, 2021
@astrogeco
Copy link
Contributor

CCB:2021-01-27 APPROVED

Just changes "send" to "write" where appropriate to ensure code written matches how it actually work

@skliper
Copy link
Contributor Author

skliper commented Jan 27, 2021

Fixed static analysis errors.

@skliper skliper marked this pull request as ready for review January 27, 2021 17:48
@astrogeco astrogeco changed the base branch from main to integration-candidate January 27, 2021 21:50
@astrogeco astrogeco merged commit e6cb6a3 into nasa:integration-candidate Jan 27, 2021
astrogeco added a commit that referenced this pull request Jan 27, 2021
@astrogeco
Merge pull request #1118 from skliper/fix1032-send_misnomer
739181c 
Fix #1032, Send->Write name update for SB write cmds
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 27, 2021
@astrogeco
Add nasa/cFE#1118
253ec90
astrogeco added a commit that referenced this pull request Feb 3, 2021
@astrogeco
Merge pull request #1118 from skliper/fix1032-send_misnomer
b7358d2 
Fix #1032, Send->Write name update for SB write cmds
astrogeco added a commit to nasa/cFS that referenced this pull request Feb 3, 2021
@astrogeco
Add cFE FastTracked PRs
a59394b 
nasa/cFE#1101
nasa/cFE#1142
nasa/cFE#1139
nasa/cFE#1147
nasa/cFE#1114
nasa/cFE#1146
nasa/cFE#1120
nasa/cFE#1115
nasa/cFE#1113
nasa/cFE#1121
nasa/cFE#1112
nasa/cFE#1118
nasa/cFE#1124
@astrogeco astrogeco mentioned this pull request Feb 15, 2021
Merged
@skliper skliper deleted the fix1032-send_misnomer branch April 1, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Caelum
Development

Successfully merging this pull request may close these issues.

Update SB "Send" command names that write to a file
2 participants
@skliper @astrogeco