Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE cmake toolchain script(s) should set OSAL_SYSTEM_BSPTYPE #438

Closed
jphickey opened this issue Dec 20, 2019 · 0 comments · Fixed by #479
Closed

CFE cmake toolchain script(s) should set OSAL_SYSTEM_BSPTYPE #438

jphickey opened this issue Dec 20, 2019 · 0 comments · Fixed by #479
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The OSAL scripts contain some convoluted logic to deal with the fact that the CFE PSP And OSAL BSP are overlapping in function. In particular the OSAL script checks CFE_SYSTEM_PSPNAME as a fallback if OSAL_SYSTEM_BSPTYPE is unset, in order to decide which BSP to use for unit tests.

It is desired to clean this up and simplify this logic.

Describe the solution you'd like
All example toolchains should set OSAL_SYSTEM_BSPTYPE so that OSAL builds a specific BSP for the platform, to be used for unit testing as well as (eventually) the PSP startup as well.

Additional context
Having this variable set simplifies the OSAL build considerably and makes it better isolated from the CFE build. A proposed change to OSAL (as part of issue nasa/osal#312) will make the OSAL_SYSTEM_BSPTYPE a required option, failing the build if it is unset

This change to the CFE toolchains should be backward-compatible.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Dec 20, 2019
jphickey added a commit to jphickey/cFE that referenced this issue Dec 20, 2019
This explicitly specifies the BSP to use when using SIMULATION=native
flags to the build.  All other example toolchain files already included
this setting.
@skliper skliper added this to the 6.8.0 milestone Dec 22, 2019
skliper pushed a commit that referenced this issue Jan 10, 2020
This explicitly specifies the BSP to use when using SIMULATION=native
flags to the build.  All other example toolchain files already included
this setting.
skliper added a commit that referenced this issue Jan 10, 2020
Fix #259 #425 #427 #435 #437 #438 #443 #445
Reviewed and approved at 2020-01-08 CCB
skliper added a commit that referenced this issue Jan 14, 2020
Fix #438: Set OSAL_SYSTEM_BSPTYPE for native builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants