Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cppcheck for cfe-core/src #425

Closed
avan989 opened this issue Dec 12, 2019 · 0 comments · Fixed by #479 or #432
Closed

cppcheck for cfe-core/src #425

avan989 opened this issue Dec 12, 2019 · 0 comments · Fixed by #479 or #432
Milestone

Comments

@avan989
Copy link
Contributor

avan989 commented Dec 12, 2019

Is your feature request related to a problem? Please describe.
Resolve cpp check warning.

[fsw/cfe-core/src/es/cfe_es_api.c:724] -> [fsw/cfe-core/src/es/cfe_es_api.c:731]: (style) Variable 'Result' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/es/cfe_es_api.c:1473] -> [fsw/cfe-core/src/es/cfe_es_api.c:1481]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/es/cfe_es_api.c:1553] -> [fsw/cfe-core/src/es/cfe_es_api.c:1555]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/es/cfe_es_api.c:1568] -> [fsw/cfe-core/src/es/cfe_es_api.c:1570]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/es/cfe_es_apps.h:177] -> [fsw/cfe-core/src/es/cfe_es_apps.c:671]: (style, inconclusive) Function 'CFE_ES_LoadLibrary' argument 2 names different: declaration 'Path' definition 'FileName'.
[fsw/cfe-core/src/es/cfe_es_apps.h:179] -> [fsw/cfe-core/src/es/cfe_es_apps.c:673]: (style, inconclusive) Function 'CFE_ES_LoadLibrary' argument 4 names different: declaration 'Name' definition 'LibName'.
[fsw/cfe-core/src/es/cfe_es_cds.c:152] -> [fsw/cfe-core/src/es/cfe_es_cds.c:160]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/es/cfe_es_cds.c:515] -> [fsw/cfe-core/src/es/cfe_es_cds.c:518]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/es/cfe_es_cds.c:699] -> [fsw/cfe-core/src/es/cfe_es_cds.c:705]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/es/cfe_es_start.h:96] -> [fsw/cfe-core/src/es/cfe_es_perf.c:62]: (style, inconclusive) Function 'CFE_ES_SetupPerfVariables' argument 1 names different: declaration 'StartType' definition 'ResetType'.
[fsw/cfe-core/src/es/cfe_es_shell.c:285] -> [fsw/cfe-core/src/es/cfe_es_shell.c:289]: (style) Variable 'Result' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/es/cfe_es_shell.c:359] -> [fsw/cfe-core/src/es/cfe_es_shell.c:379]: (style) Variable 'Result' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/es/cfe_es_start.h:95] -> [fsw/cfe-core/src/es/cfe_es_start.c:483]: (style, inconclusive) Function 'CFE_ES_InitializeFileSystems' argument 1 names different: declaration 'StartType' definition 'start_type'.
[fsw/cfe-core/src/es/cfe_es_start.c:51] -> [fsw/cfe-core/src/es/cfe_es_start.c:961]: (style, inconclusive) Function 'CFE_ES_MainTaskSyncDelay' argument 1 names different: declaration 'AppMinState' definition 'AppStateId'.
[fsw/cfe-core/src/es/cfe_es_log.h:254] -> [fsw/cfe-core/src/es/cfe_es_syslog.c:352]: (style, inconclusive) Function 'CFE_ES_SysLogSetMode' argument 1 names different: declaration 'LogMode' definition 'Mode'.
[fsw/cfe-core/src/es/cfe_es_log.h:277] -> [fsw/cfe-core/src/es/cfe_es_syslog.c:376]: (style, inconclusive) Function 'CFE_ES_SysLog_vsnprintf' argument 4 names different: declaration 'ArgPtr' definition 'ap'.
[fsw/cfe-core/src/fs/cfe_fs_api.c:169] -> [fsw/cfe-core/src/fs/cfe_fs_api.c:176]: (style) Variable 'Result' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/fs/cfe_fs_decompress.c:206]: (style) Variable 'stamp' is assigned a value that is never used.
[fsw/cfe-core/src/fs/cfe_fs_priv.c:66] -> [fsw/cfe-core/src/fs/cfe_fs_priv.c:68]: (style) Variable 'Stat' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/sb/cfe_sb_priv.h:354] -> [fsw/cfe-core/src/sb/cfe_sb_api.c:2107]: (style, inconclusive) Function 'CFE_SB_ReadQueue' argument 1 names different: declaration 'pd' definition 'PipeDscPtr'.
[fsw/cfe-core/src/sb/cfe_sb_priv.h:355] -> [fsw/cfe-core/src/sb/cfe_sb_api.c:2109]: (style, inconclusive) Function 'CFE_SB_ReadQueue' argument 3 names different: declaration 'time_out' definition 'Time_Out'.
[fsw/cfe-core/src/sb/cfe_sb_priv.h:355] -> [fsw/cfe-core/src/sb/cfe_sb_api.c:2110]: (style, inconclusive) Function 'CFE_SB_ReadQueue' argument 4 names different: declaration 'message' definition 'Message'.
[fsw/cfe-core/src/sb/cfe_sb_priv.h:369] -> [fsw/cfe-core/src/sb/cfe_sb_buf.c:60]: (style, inconclusive) Function 'CFE_SB_GetBufferFromPool' argument 2 names different: declaration 'size' definition 'Size'.
[fsw/cfe-core/src/sb/cfe_sb_init.c:88] -> [fsw/cfe-core/src/sb/cfe_sb_init.c:93]: (style) Variable 'Stat' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/sb/cfe_sb_init.c:220]: (style) Unused variable: KeyVal
[fsw/cfe-core/src/sb/cfe_sb_priv.h:405] -> [fsw/cfe-core/src/sb/cfe_sb_priv.c:793]: (style, inconclusive) Function 'CFE_SB_AddDest' argument 2 names different: declaration 'Dest' definition 'NewNode'.
[fsw/cfe-core/src/sb/cfe_sb_priv.h:406] -> [fsw/cfe-core/src/sb/cfe_sb_priv.c:841]: (style, inconclusive) Function 'CFE_SB_RemoveDest' argument 2 names different: declaration 'Dest' definition 'NodeToRemove'.
[fsw/cfe-core/src/sb/cfe_sb_priv.c:708]: (style) Variable 'Val' is assigned a value that is never used.
[fsw/cfe-core/src/sb/cfe_sb_task.c:140] -> [fsw/cfe-core/src/sb/cfe_sb_task.c:142]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/sb/cfe_sb_util.c:112]: (style) Unused variable: size
[fsw/cfe-core/src/tbl/cfe_tbl_api.c:65] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:74]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_api.c:519] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:527]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_api.c:1051] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:1058]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_api.c:1206] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:1213]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_api.c:1419] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:1425]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_api.c:1524] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:1531]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_api.c:1568] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:1576]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_api.c:1645] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:1651]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_internal.c:380] -> [fsw/cfe-core/src/tbl/cfe_tbl_internal.c:383]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_internal.c:540] -> [fsw/cfe-core/src/tbl/cfe_tbl_internal.c:545]: (style) Variable 'Status' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_internal.c:1463] -> [fsw/cfe-core/src/tbl/cfe_tbl_internal.c:1466]: (style) Variable 'Status' is reassigned a value before the old one has been used.

Requester Info
Anh Van, NASA Goddard

skliper pushed a commit that referenced this issue Jan 10, 2020
skliper added a commit that referenced this issue Jan 10, 2020
Fix #259 #425 #427 #435 #437 #438 #443 #445
Reviewed and approved at 2020-01-08 CCB
skliper added a commit that referenced this issue Jan 14, 2020
@skliper skliper linked a pull request Sep 24, 2021 that will close this issue
@skliper skliper added this to the 6.8.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants