Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #93, Adds format check and static analysis workflows #205

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

chillfig
Copy link
Contributor

@chillfig chillfig commented Mar 22, 2022

Checklist (Please check before submitting)

Describe the contribution
Fixes #93

Testing performed
Tested format check on fork: https://github.com/chillfig/CF/runs/5662467104?check_suite_focus=true

Tested static analysis on fork: https://github.com/chillfig/CF/runs/5662467266?check_suite_focus=true

Expected behavior changes
Passing workflow

System(s) tested on
Ubuntu 18.04

Additional context
The added format check workflow catches a format check error when it runs its "error on differences" step. Specifically, the workflow throws errors on the placement of "*" with pointer variables written in the fsw and unit test files. The format check would rather that "*" be on the left side of the whitespace than the right side.

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, ASRC Federal

@skliper
Copy link
Contributor

skliper commented Mar 23, 2022

What happened to the format check? It's OK that it fails, we can submit a merge to fix once the other merges are in.

@chillfig
Copy link
Contributor Author

@skliper The format check failed on the "Error on differences" step from within the script. According to github actions, the process exited with error code 255 in this step after it identified failure in files primarily from the unit-test repo, but also a few from the fsw repo.

@astrogeco astrogeco changed the title Fix #93, Adds format check workflow Partial #93, Adds format check and static analysis workflows Mar 23, 2022
@astrogeco astrogeco changed the title Partial #93, Adds format check and static analysis workflows Fix #93, Adds format check and static analysis workflows Mar 23, 2022
@astrogeco
Copy link
Contributor

It might have to do with the clang-format version differences that Joe mentioned in #93

@astrogeco
Copy link
Contributor

@chillfig looks like the second commit deleted the format check workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add format check and static-analysis workflows
3 participants