Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add format check and static-analysis workflows #93

Closed
astrogeco opened this issue Dec 6, 2021 · 1 comment · Fixed by #205
Closed

Add format check and static-analysis workflows #93

astrogeco opened this issue Dec 6, 2021 · 1 comment · Fixed by #205
Assignees
@ArielSAdamsNASA
Labels
continuous-integration draco-rc1 enhancement
Milestone
Draco

Comments

@astrogeco
Copy link
Contributor

astrogeco commented Dec 6, 2021 •
edited
Loading

Add format check workflow to continuous integration to ensure new commits meet style guide

See

https://github.com/nasa/sch_lab/blob/main/.github/workflows/format-check.yml
@jphickey
Copy link
Contributor

jphickey commented Dec 8, 2021

Side note - when I ran the initial scrub, I used clang-format-13. It looks like this defaults to a slightly different spacing for the pointer declarations (whether the * is on the right or left side of the whitespace) than the version of clang-format used in other repos.

So, we might need to do another pass with the older version before this will be "clean" (but the diffs should be relatively minor, unlike from the first pass...)

astrogeco added a commit to astrogeco/CF that referenced this issue Jan 20, 2022
@astrogeco
Fix nasa#93, Add format check workflow
3b64653
astrogeco added a commit to astrogeco/CF that referenced this issue Jan 20, 2022
@astrogeco
Fix nasa#93, Add format check workflow
3dc936e
chillfig added a commit to chillfig/CF that referenced this issue Mar 22, 2022
@chillfig
Fix nasa#93, Adds format check workflow
0c4869b
@chillfig chillfig mentioned this issue Mar 22, 2022
Merged
2 tasks
chillfig added a commit to chillfig/CF that referenced this issue Mar 22, 2022
@chillfig
Fix nasa#93, Adds static analysis workflow
d98e216
@astrogeco astrogeco changed the title Add format check workflow Add format check and static-analysis workflows Mar 23, 2022
chillfig added a commit to chillfig/CF that referenced this issue Mar 23, 2022
@chillfig
Fix nasa#93, Adds format check and static analysis workflows
0ed0e26
astrogeco added a commit that referenced this issue Mar 23, 2022
@astrogeco
Merge pull request #205 from chillfig/cf_add_workflow
80cafe9 
Fix #93, Adds format check and static analysis workflows
@skliper skliper added this to the Draco milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArielSAdamsNASA ArielSAdamsNASA

Labels
continuous-integration draco-rc1 enhancement
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #93, Adds format check and static analysis workflows chillfig/CF
4 participants
@jphickey @skliper @astrogeco @ArielSAdamsNASA