-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent results when using call-mods + pileup or pileup directly #132
Comments
For completeness when using call-mods + pileup using the same filtering thresholds I get identical results as when using pileup with --no-filtering so:
pileup_C is identical to pileup_A (but both are significantly different to pileup_B). |
Hello @ppapasaikas, I'm a little confused how you're generating |
Thank you for the quick reply.
I am using modkit v.0.2.3. I am using directly the generated modkit pileup outputs in all cases to assess %mA. |
Hello @ppapasaikas, You may get different results from running
The exact line number might be different if you update to a more recent version of modkit. What I would suggest is running I'll add an option to |
I followed the suggested procedure:
(Again for the above case in the second step replacing And
The two resulting pileups are definitely not identical. Not only in terms of fraction modified but also Nvalid_cov and all other Nxxx columns of the bedmethyl file. The difference is not subtle either. pileup1 (the version going through call-mods) reports consistently higher Nvalid_cov and lower fraction modified. In case you cannot replicate with an in-house dataset I can share a sample bam file. |
Hello @ppapasaikas, If you can share a BAM that exposes the issue that would help a lot and I'd be more than happy to take a look. Thanks! |
Any update, keen to investigate the problem if you're willing to share a BAM that exposes it. |
I noticed a discrepancy in the obtained calls when using in succession modkit pileup on a bam file obtained with modkit call-mods vs a pileup directly obtained from modkit pileup.
Using call-mods + pileup:
Using pileup directly:
I would naively expect the two resulting pileups to be identical or at least close in terms of reported %mA and yet average methylation differs significantly (>10% on my data, ~65% vs 78%).
Perhaps I am missing something in the way modkit call-mods operates?
The text was updated successfully, but these errors were encountered: