Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PAIR v0 not finalizing the pollables when closing socket #1640

Merged
merged 1 commit into from
Feb 5, 2023
Merged

Fix PAIR v0 not finalizing the pollables when closing socket #1640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix PAIR v0 not finalizing the pollables when closing socket 
This function needs to be pretty much identical between PAIR v0 and
v1, it was missing just the call to release the pollable resources.
  • Loading branch information
@jimenezrick
jimenezrick committed Jan 30, 2023
commit a5ccc29e4fcf10c938a15e7251585c0e6c8a26a5
2 changes: 2 additions & 0 deletions src/sp/protocol/pair0/pair.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ pair0_sock_fini(void *arg)

nni_lmq_fini(&s->rmq);
nni_lmq_fini(&s->wmq);
nni_pollable_fini(&s->writable);
nni_pollable_fini(&s->readable);
nni_mtx_fini(&s->mtx);
}

Expand Down