Fix PAIR v0 not finalizing the pollables when closing socket #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function needs to be pretty much identical between PAIR v0 and v1, it was missing just the call to release the pollable resources.
|
Thanks for the fix! |
|
The leaks in the test suites are unrelated to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function needs to be pretty much identical between PAIR v0 and v1, it was missing just the call to release the pollable resources.
I was testing the compat API and i discovered that when using PAIR v0, it was leaking file descriptors because of this. This solves the problem completely mirroring the same logic present in PAIR v1 (https://github.com/nanomsg/nng/blob/master/src/sp/protocol/pair1/pair.c#L79-L80).