Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return scopes on executions (no-changelog) #10310

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

valya
Copy link
Contributor

@valya valya commented Aug 6, 2024

Summary

Adds scopes to the executions list. This is to allow the frontend to remove the delete button for the to be released viewer role.

Related Linear tickets, Github issues, and Community forum posts

PAY-1789

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 6, 2024
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor comments

packages/cli/src/executions/execution.service.ts Outdated Show resolved Hide resolved
packages/cli/src/executions/execution.service.ts Outdated Show resolved Hide resolved
packages/cli/src/workflows/workflowSharing.service.ts Outdated Show resolved Hide resolved
Copy link

cypress bot commented Aug 7, 2024



Test summary

394 0 0 0Flakiness 1


Run details

Project n8n
Status Passed
Commit 27eaa6d
Started Aug 7, 2024 8:45 AM
Ended Aug 7, 2024 8:50 AM
Duration 04:42 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


Flakiness

e2e/12-canvas.cy.ts Flakiness
1 Canvas Node Manipulation and Navigation > should preserve connections after rename & node-view switch

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

github-actions bot commented Aug 7, 2024

✅ All Cypress E2E specs passed

@valya valya merged commit fa17391 into master Aug 7, 2024
32 checks passed
@valya valya deleted the pay-1789-add-scopes-to-global-executions-view branch August 7, 2024 09:19
@janober
Copy link
Member

janober commented Aug 7, 2024

Got released with [email protected]

MiloradFilipovic added a commit that referenced this pull request Aug 7, 2024
* master:
  refactor(core): Centralize scaling mode (no-changelog) (#9835)
  fix(editor): Remove body padding from storybook previews (no-changelog) (#10317)
  feat(MySQL Node): Return decimal types as numbers (#10313)
  🚀 Release 1.54.0 (#10315)
  feat(Elasticsearch Node): Add bulk operations for Elasticsearch (#9940)
  feat(Stripe Trigger Node): Add Stripe webhook descriptions based on the workflow ID and name (#9956)
  feat(MongoDB Node): Add projection to query options on Find (#9972)
  fix(Invoice Ninja Node): Fix payment types (#10196)
  feat(HTTP Request Tool Node): Use DynamicStructuredTool with models supporting it (no-changelog) (#10246)
  feat: Return scopes on executions (no-changelog) (#10310)
  feat(Webflow Node): Update to use the v2 API (#9996)
  feat(Lemlist Trigger Node): Update Trigger events (#10311)
  feat(Calendly Trigger Node): Update event names (no-changelog) (#10129)
  refactor(core): Reorganize webhook related components under src/webhooks (no-changelog) (#10296)
  docs: Fix links to license files in readme (no-changelog) (#10257)
  fix(editor): Update design system Avatar component to show initials also when only firstName or lastName is given (#10308)
  fix(editor): Update tags filter/editor to not show non existing tag as a selectable option (#10297)
  fix(editor): Update project tabs test (no-changelog) (#10300)
  fix(core): VM2 sandbox should not throw on `new Promise` (#10298)

# Conflicts:
#	packages/design-system/src/components/N8nAvatar/Avatar.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants