refactor(core): Reorganize webhook related components under src/webhooks (no-changelog) #10296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For easier discoverability and cohesion, group webhook related files and components under `src/webhooks` directory.
tomi
commented
Aug 5, 2024
| @@ -239,34 +238,6 @@ export interface IExternalHooksFunctions { | |||
| }; | |||
| } | |||
|
|
|||
| export type WebhookCORSRequest = Request & { method: 'OPTIONS' }; | |||
There was a problem hiding this comment.
Moved to webhook.types.ts
tomi
commented
Aug 5, 2024
| @@ -0,0 +1,37 @@ | |||
| import type { Request, Response } from 'express'; | |||
There was a problem hiding this comment.
These were moved from Interfaces.ts
tomi
added a commit
that referenced
this pull request
Aug 5, 2024
Builds on top of #10296. Move webhook request handler to own class.
4 tasks
ivov
approved these changes
Aug 7, 2024
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
|
✅ All Cypress E2E specs passed |
tomi
added a commit
that referenced
this pull request
Aug 7, 2024
Builds on top of #10296. Move webhook request handler to own class.
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 7, 2024
* master: refactor(core): Centralize scaling mode (no-changelog) (#9835) fix(editor): Remove body padding from storybook previews (no-changelog) (#10317) feat(MySQL Node): Return decimal types as numbers (#10313) 🚀 Release 1.54.0 (#10315) feat(Elasticsearch Node): Add bulk operations for Elasticsearch (#9940) feat(Stripe Trigger Node): Add Stripe webhook descriptions based on the workflow ID and name (#9956) feat(MongoDB Node): Add projection to query options on Find (#9972) fix(Invoice Ninja Node): Fix payment types (#10196) feat(HTTP Request Tool Node): Use DynamicStructuredTool with models supporting it (no-changelog) (#10246) feat: Return scopes on executions (no-changelog) (#10310) feat(Webflow Node): Update to use the v2 API (#9996) feat(Lemlist Trigger Node): Update Trigger events (#10311) feat(Calendly Trigger Node): Update event names (no-changelog) (#10129) refactor(core): Reorganize webhook related components under src/webhooks (no-changelog) (#10296) docs: Fix links to license files in readme (no-changelog) (#10257) fix(editor): Update design system Avatar component to show initials also when only firstName or lastName is given (#10308) fix(editor): Update tags filter/editor to not show non existing tag as a selectable option (#10297) fix(editor): Update project tabs test (no-changelog) (#10300) fix(core): VM2 sandbox should not throw on `new Promise` (#10298) # Conflicts: # packages/design-system/src/components/N8nAvatar/Avatar.vue
tomi
added a commit
that referenced
this pull request
Aug 9, 2024
Builds on top of #10296. Move webhook request handler to own class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For easier discoverability and cohesion, group webhook related files and components under
src/webhooksdirectory.Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)