Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom invisible color #24256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XiaoMigros
Copy link
Contributor

Resolves: #24054

Note this PR doesn't allow for a custom color of selected invisible items, those are currently the selection color at 40% opacity

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@wizofaus
Copy link
Contributor

Tested this out, seems fine - I did originally think it'd be nice to have control over the degree of opacity for selected invisible notes but at least for me on my monitor I didn't feel any need to adjust it even after setting invisibleColor to #d0d0d0 (which is quite pale, but what I want - just enough to see there's something there but not getting in the way of what will be printed).

Copy link
Contributor

@wizofaus wizofaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XiaoMigros
Copy link
Contributor Author

I did originally think it'd be nice to have control over the degree of opacity for selected invisible notes

I believe that to be a separate issue - see #13652
Thanks for taking a look!

@Jojo-Schmitz
Copy link
Contributor

Any reason not to merge this?

@zacjansheski
Copy link
Contributor

In this PR, invisible accidentals are not displayed

video1422447981.mp4

@XiaoMigros
Copy link
Contributor Author

Rebased to include #24306, should be good now!

Copy link

@avvvvve avvvvve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! "Invisible color" is kind of a funny title, but there's not really a better way to put it without making it longer.

@avvvvve avvvvve self-requested a review November 20, 2024 15:33
Copy link

@avvvvve avvvvve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XiaoMigros Zac just noticed that the invisible color is incorrectly being applied to the speaker icon in the sound flag button. That icon should just be black (#000000).

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom colour for display of invisible items
6 participants