-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for custom invisible color #24256
base: master
Are you sure you want to change the base?
Conversation
68fd170
to
9de182d
Compare
Tested this out, seems fine - I did originally think it'd be nice to have control over the degree of opacity for selected invisible notes but at least for me on my monitor I didn't feel any need to adjust it even after setting invisibleColor to #d0d0d0 (which is quite pale, but what I want - just enough to see there's something there but not getting in the way of what will be printed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I believe that to be a separate issue - see #13652 |
Any reason not to merge this? |
In this PR, invisible accidentals are not displayed video1422447981.mp4 |
9de182d
to
5d2d293
Compare
Rebased to include #24306, should be good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! "Invisible color" is kind of a funny title, but there's not really a better way to put it without making it longer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XiaoMigros Zac just noticed that the invisible color is incorrectly being applied to the speaker icon in the sound flag button. That icon should just be black (#000000).
Resolves: #24054
Note this PR doesn't allow for a custom color of selected invisible items, those are currently the selection color at 40% opacity