Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Regression: opacity control missing in color picker #13652

Open
MarcSabatella opened this issue Oct 7, 2022 · 5 comments · May be fixed by #16201
Open

[MU4 Issue] Regression: opacity control missing in color picker #13652

MarcSabatella opened this issue Oct 7, 2022 · 5 comments · May be fixed by #16201
Assignees
Labels
good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute

Comments

@MarcSabatella
Copy link
Contributor

Describe the bug
MuseScore 4 lacks the opacity control in the color picker - needed for creating highlighter effects

To Reproduce
Steps to reproduce the behavior:

  1. Add a staff text
  2. Set the Frame to rectangle in Properties
  3. Click the color swatch to set the flll color
  4. See error: no opacity control

Expected behavior
An opacity control is needed to create translucent effects, such as mimicking a yellow highlighter pen

Screenshots
This is how it looked in MuseScore 3, and shows how the feature was commonly used by educators:
image

Platform information

  • OS: Linux

Additional context
In MU3, it was very annoyingly necessary to explicitly set this to 255 if you wanted to actually see the background color at all - the default was 0. Glad to see that opening this dialog now sets the color to opaque. But, there still needs to be a way to set it to intermediate values like 127. And, a small complication - that value, once explicitly set, should remain set and not get arbitrarily changed to 255 every time you open the dialog. So, whatever magic happens to force the opacity to 255 upon setting a color, should be smart enough not to do this if there is an explicit opacity value already set.

@musescore musescore deleted a comment from rgreen5 Jan 13, 2023
@cbjeukendrup cbjeukendrup added the good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute label Jan 13, 2023
@octopols
Copy link
Contributor

I want to work on this, can you please assign me this issue?

@octopols
Copy link
Contributor

I was able to add the alpha channel in the colour picker but the task also said that the solution should be smart enough to realise when alpha is 0 and set it to max (atleast that's how I interpreted the problem).
I was able to compare QColors but is there a way by which I can change the alpha value of an already existing QColor?

@cbjeukendrup
Copy link
Contributor

@octopols
Copy link
Contributor

How about https://doc.qt.io/qt-5/qcolor.html#setAlpha?

Thanks a lot, this is what I needed.

@octopols
Copy link
Contributor

octopols commented Feb 3, 2023

issue_13652_fix.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute
Projects
None yet
3 participants