GSoC '24 - Dynamics Popup - Part 4

[kettogg]

This is the fourth part of the main pull request: #23038, which adds the preview of dynamic on hovering.

PR for part 1: #24125
PR for part 2: #24147
PR for part 3: #24152

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[Jojo-Schmitz]

GSoC '24 - Dynamics Popup - Part 4 vs. This is the third part of the main pull request ?!?

Somehow reminds me of "Hitchhikers' Guide to the Galaxy - a trilogy in four parts" (and its 5th part ;-))

[kettogg]

This is the third part of the main pull request ?!?

Oops! I forgot to edit, thanks for catching it @Jojo-Schmitz (I was a bit sleepy yesterday) 😅

[avvvvve]

Some UI feedback:

1. The vertical position of the grey box varies depending on the dynamic you're hovering on. The position for mf, f, ff, and fp are the correct height (just some examples). p through pppppp and mp are too low.

Screen.Recording.2024-10-22.at.7.03.17.PM.mov

2. If possible, the text entry cursor line should not be shown before the "previewed" dynamic while hovering on a button. We should continue to show it while nothing is being hovered, so that a user can type in a dynamic (another community PR has started to tackle typing in dynamics).

3. If I focus away from MS Studio while the popup is open, the popup disappears but the editing field stays in place. Ideally, the popup should just stay open or reappear. If we can't do that, we should exit edit mode too

   • If you were editing an existing dynamic, leave edit mode and keep the dynamic selected
   

Lower priority:
4. This is a change, but instead of making the previewed dynamic grey, let's make it look the same as a hidden dynamic that is selected - that is, a lighter tint of its assigned voice color as pictured below

UX note:
Not sure if @mike-spa's work on resizing a hairpin when dragging a snapped dynamic was merged before or after this was worked on, but it's not present in this PR. Once we merge this, we need to test that dragging a dynamic around still works as expected.