GSoC '24 - Dynamics Popup - Part 3

[kettogg]

This is the third part of the main pull request: #23038, which adds functionality to add dynamic using shortcut, opening of popup when hairpin ends on a note or rest and the automatic switching of hairpin type.

PR for part 1: #24125
PR for part 2: #24147

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[avvvvve]

Apologies for the time it's taken to start reviewing parts 2-4, but here's some feedback:

Issue 1

After dragging a hairpin out from a dynamic, I don't see the popup appear. I'm assuming it's supposed to in this PR based on the description?

Screen.Recording.2024-10-22.at.5.34.16.PM.mov

Issue 2 (crash)

If a hairpin has a dynamic at either end but NOT both ends, and I click the dynamic and change it via the popup, it crashes.

1. Add a dynamic followed by a hairpin via any method (shortcut, popup, dragging, palettes - doesn't matter)
2. Click the dynamic
3. Click any dynamic in the popup
4. Crash

Screen.Recording.2024-10-22.at.5.38.24.PM.mov

The automatic switching of hairpin direction looks good!