Fix #10601: Added Edit and Reset workspace button #13279

HemantAntony · 2022-09-10T10:46:20Z

Resolves: #10601

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made

cbjeukendrup · 2022-09-10T13:12:08Z

src/workspace/internal/workspaceactioncontroller.cpp

 dispatcher()->reg(this, "configure-workspaces", this, &WorkspaceActionController::openConfigureWorkspacesDialog);
+ dispatcher()->reg(this, "reset-workspace", [this]() { setCurrentWorkspaceName(DEFAULT_WORKSPACE_NAME); });


As I explained in #12658 (comment), this will not really reset the workspace... not sure what to do about that.

How about basing the default workspace of a "Default workspace template" (not exposed to users). But we can call it the default workspace since for the users its the workspace that they use (by default).

So, whenever we want to reset it to default workspace, we just delete the default workspace and create a new default workspace based off of the template.

Actually 'reset workspace' doesn't work for me in MU3 at all.
So I don't know how it is should work.

In the beginning, I thought that this should reset the current workspace to default state.
But here I see that we are resetting the selection to the default workspace, not the state

Eism · 2023-01-10T11:16:04Z

src/appshell/view/appmenumodel.cpp

- << makeMenuItem("configure-workspaces");
+ << makeMenuItem("edit-workspace")
+ << makeMenuItem("configure-workspaces")
+ << makeMenuItem("reset-workspace");


Maybe it is not a good place for 'edit-workspace' and 'reset-workspace'.
Because these two options affect to current workspace, 'configure-workspaces' affects all workspaces.

@Tantacrul
What do you think about adding these two operations to the Workspaces dialog for each workspace? Like in Parts dialog

Tantacrul · 2023-01-10T11:42:09Z

I'm unable to test this because the builds have expired. @HemantAntony - can you fix this up and I'll take a look? Thanks!

@Eism - I do worry (from what you are saying) that there might be some redundancy here. Need to test it to be sure.

HemantAntony · 2023-01-10T14:27:49Z

@Tantacrul It should be okay now

Tantacrul · 2023-01-13T14:33:28Z

@Eism

What do you think about adding these two operations to the Workspaces dialog for each workspace? Like in Parts dialog

I agree. @HemantAntony - I don't think this is the right place to put those options because they are hard to find and are much less clear than they would be if they were located in the 'Configure Workspaces' popup. I'd suggest leaving the options in the top menu but also creating some UI options in the Workspace popup itself.

Perhaps @bkunda can help with this?

Tantacrul · 2023-01-13T14:36:57Z

Actually, I'm confused about what 'Reset Workspace' is supposed to do. In this build, it seems to simply choose the default workspace and that's it. Even if I change the default workspace, pressing 'Reset' doesn't do anything.

If this is all it does, then I don't think we should have this option at all. Anyone have any ideas?

MarcSabatella · 2023-01-13T15:12:13Z

I can tell you what I would want it to, which is not what it has done in the past: I'd want it to reset any customizations I had made during that particular editing session. So if I had a nice carefully customized workspace I had been using for weeks, then one day I accidentally messed it up, I could easily go back to the way it was when I started that session. This would be easy to implement I think since as far as I know we don't actually write the customizations out until your either close the window or change workspaces. So basically it would just amount to reloading the current workspace.

What it actually did in MU3 was something rather different, and sort of useful but not really. When you create a workspace, it's cloned from whatever workspace you are in. So you can start form either Basic and add to it, or from Advanced and subtracted from it. Reset takes you back to either Basic or Advanced - whichever your workspace was based on. You can also base one custom workspace off of another, which is nice, but reset still takes you all the way back to Basic or Advanced rather than back to the workspace you actually based yours on. Seems like there was some technical reason for that but I don't remember.

Tantacrul · 2023-01-14T10:17:53Z

So, I guess you'd need two options then:

Reset workspace: does what it says - resets the selected workspace back to the initial default the app is loaded with. Anything else is just confusing.

Undo changes to workspace in this session: again, does what it says, although I'd like to think of a snappier name. Perhaps Undo recent changes?

And these options should be clearly applicable to individual workspaces, possibly using a '...' button on each.

Tantacrul · 2023-01-14T10:21:29Z

@HemantAntony - if you think you'd be comfortable implementing a design like we've just discussed, I can put it together for you?

Apologies for the changes. The MS3 system just feels dislocated and hard to understand. I still don't actually know what it exactly does!

HemantAntony · 2023-01-14T10:25:23Z

@Tantacrul That would be great! I'll work on it :)

HemantAntony · 2023-07-14T04:06:35Z

@Tantacrul Just pinging you in case you forgot

Tantacrul · 2023-07-14T09:17:35Z

Hey @HemantAntony, I wasn't aware I needed to do anything. 😆 I did just try to grab a build but it has expired.

Have you implemented changes and want them tested?

HemantAntony · 2023-07-14T10:21:09Z

Ah no 😁. You had said that you would implement a design for 'Edit workspace' and 'Undo recent changes' in the above comments

Tantacrul · 2023-07-14T14:39:17Z

Sure. I think you're right that it needs a visualisation (and possibly a little double-checking on the UX). I'll bump this over to @bkunda and @jessjwilliamson. They'll likely be able to bang it out quite quickly and give it to you.

Right now, I'm a bit too consumed with other things to do the design myself. Apologies!

HemantAntony · 2023-07-14T15:00:05Z

I see, no problem!

HemantAntony mentioned this pull request Sep 10, 2022

[MU4 Issue] [Workspaces] Edit and Reset workspace options are missing in Workspace menu #10601

Open

cbjeukendrup reviewed Sep 10, 2022

View reviewed changes

cbjeukendrup added the strings Affects translatable strings label Sep 26, 2022

cbjeukendrup requested review from RomanPudashkin and Eism September 26, 2022 21:04

Eism reviewed Jan 10, 2023

View reviewed changes

Fix musescore#10601: Added Edit and Reset workspace button

15862d6

HemantAntony force-pushed the 10601-missing_edit_and_reset_workspace_options branch from 5968558 to 15862d6 Compare January 10, 2023 13:03

igorkorsukov force-pushed the master branch 6 times, most recently from fa1f8d3 to 525a11a Compare February 14, 2024 09:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #10601: Added Edit and Reset workspace button #13279

Fix #10601: Added Edit and Reset workspace button #13279

HemantAntony commented Sep 10, 2022

cbjeukendrup Sep 10, 2022

HemantAntony Sep 10, 2022 •

edited

Loading

Eism Jan 10, 2023

Eism Jan 10, 2023

Tantacrul commented Jan 10, 2023 •

edited

Loading

HemantAntony commented Jan 10, 2023

Tantacrul commented Jan 13, 2023

Tantacrul commented Jan 13, 2023 •

edited

Loading

MarcSabatella commented Jan 13, 2023

Tantacrul commented Jan 14, 2023 •

edited

Loading

Tantacrul commented Jan 14, 2023 •

edited

Loading

HemantAntony commented Jan 14, 2023

HemantAntony commented Jul 14, 2023

Tantacrul commented Jul 14, 2023 •

edited

Loading

HemantAntony commented Jul 14, 2023

Tantacrul commented Jul 14, 2023

HemantAntony commented Jul 14, 2023

		dispatcher()->reg(this, "configure-workspaces", this, &WorkspaceActionController::openConfigureWorkspacesDialog);
		dispatcher()->reg(this, "reset-workspace", [this]() { setCurrentWorkspaceName(DEFAULT_WORKSPACE_NAME); });

Fix #10601: Added Edit and Reset workspace button #13279

Are you sure you want to change the base?

Fix #10601: Added Edit and Reset workspace button #13279

Conversation

HemantAntony commented Sep 10, 2022

cbjeukendrup Sep 10, 2022

Choose a reason for hiding this comment

HemantAntony Sep 10, 2022 • edited Loading

Choose a reason for hiding this comment

Eism Jan 10, 2023

Choose a reason for hiding this comment

Eism Jan 10, 2023

Choose a reason for hiding this comment

Tantacrul commented Jan 10, 2023 • edited Loading

HemantAntony commented Jan 10, 2023

Tantacrul commented Jan 13, 2023

Tantacrul commented Jan 13, 2023 • edited Loading

MarcSabatella commented Jan 13, 2023

Tantacrul commented Jan 14, 2023 • edited Loading

Tantacrul commented Jan 14, 2023 • edited Loading

HemantAntony commented Jan 14, 2023

HemantAntony commented Jul 14, 2023

Tantacrul commented Jul 14, 2023 • edited Loading

HemantAntony commented Jul 14, 2023

Tantacrul commented Jul 14, 2023

HemantAntony commented Jul 14, 2023

HemantAntony Sep 10, 2022 •

edited

Loading

Tantacrul commented Jan 10, 2023 •

edited

Loading

Tantacrul commented Jan 13, 2023 •

edited

Loading

Tantacrul commented Jan 14, 2023 •

edited

Loading

Tantacrul commented Jan 14, 2023 •

edited

Loading

Tantacrul commented Jul 14, 2023 •

edited

Loading