-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU4 Issue] Default workspace name not translatable, because logic relies on it #12658
Comments
In fact, the only reason that we need to check whether a workspace is the default one, is that we don't allow deleting the default workspace. Do we really want to disallow this? Or do we rather want that the user can simply not delete the last remaining workspace (i.e. there always has to exist at least one workspace)? |
@cbjeukendrup - we specified that the default workspace can't be deleted in case users really need it to revert settings they messed up. I don't have opinions on how this should be achieved. |
But when the user makes changes without creating a new workspace first, this is saved in the default workspace. So, when you just start using MuseScore, you are in the default workspace, and if you then mess up workspace-related settings, these will be stored in the default workspace, so there isn't anything you can switch back to. (The only thing you can do to revert the messed-up 'default' workspace to the real default, is doing a factory reset (or deleting the workspace file from hidden user folders).) |
yeah, you're right. Oh well then. The option to just enforce '1 workspace at all times' is good. We'll need to spruce up this system in other releases. |
Describe the bug
The name of the default workspace (
"Default"
) is not translatable, and we can't easily make it translatable because there is some logic relying on it (logic to determine which one is the built-in default workspace).To Reproduce
Steps to reproduce the behavior:
workspacetypes.h
We should make a better way to determine which workspace is the default one, instead of relying on the name. (I don't think we should still have logic relying on the name after we make it translatable. Relying on translatable names is asking for trouble, if you ask me.)
(For the translators, this doesn't have high priority, because the string "Default" already exists in other contexts, so Transifex's translation memory will just copy the translation from those strings.)
The text was updated successfully, but these errors were encountered: