Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Loop region length is not recalculated after tempo change/tempo slider change #12972

Open
abariska opened this issue Aug 22, 2022 · 5 comments
Labels
P2 Priority: Medium

Comments

@abariska
Copy link

To Reproduce
Steps to reproduce the behavior:

  1. Create a simple score with notes
  2. Enable a loop for two measures
  3. Put the tempo change to the first measure of the loop region
  4. Play
  5. Pay attention to the loop region length

Expected behavior
Loop region length is recalculated after tempo change according to the new tempo

Screenshots

Capture.2022-08-23_12-38-35_AM.mov
@abariska abariska added the P2 Priority: Medium label Aug 22, 2022
@abariska abariska added this to Needs triage in [MU4.0 BETA1] via automation Aug 22, 2022
@Obliquely
Copy link
Contributor

This is a different issue, but perhaps the fix would be similar. RomanPudashkin@2e59307

@vpereverzev vpereverzev moved this from Needs triage to Low priority in [MU4.0 BETA1] Aug 29, 2022
RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Sep 2, 2022
@RomanPudashkin RomanPudashkin moved this from Low priority to In progress in [MU4.0 BETA1] Sep 2, 2022
@abariska
Copy link
Author

abariska commented Sep 7, 2022

@RomanPudashkin Please, pay attention that after undo applied there's a similar issue reproduces

CleanShot.2022-09-07.at.16.19.23.mp4

@abariska
Copy link
Author

Also, playback cursor position is moved back out of loop region when making tempo way slower via slider on undocked transport panel. It's not a regression but could be related to current issue.

CleanShot.2022-09-12.at.17.20.59.mp4

RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Sep 29, 2022
@abariska
Copy link
Author

abariska commented Sep 30, 2022

Info: Only main case was fixed and merged but bugs in the last two comments were not

@Tantacrul Tantacrul removed this from In progress in [MU4.0 BETA1] Oct 18, 2022
@Tantacrul Tantacrul added this to To triage in [MU4.0 RELEASE] via automation Oct 18, 2022
@Tantacrul Tantacrul moved this from To triage to In progress in [MU4.0 RELEASE] Oct 18, 2022
RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Oct 21, 2022
@RomanPudashkin RomanPudashkin moved this from In progress to Medium Priority in [MU4.0 RELEASE] Oct 21, 2022
@Tantacrul Tantacrul removed this from Medium Priority in [MU4.0 RELEASE] Nov 22, 2022
@Tantacrul Tantacrul added this to To do in 4.x SHORTLIST via automation Nov 22, 2022
@Tantacrul Tantacrul added this to To do in [MU4 - MPE] via automation Nov 22, 2022
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 19, 2023

Just came up again in https://musescore.org/en/node/345254
It is not just when adding a tempo change, it seems to happen on every score that is not at the default tempo (of 120BPM)

Hmm, maybe not, might be a different issue

@DmitryArefiev DmitryArefiev changed the title [MU4 Issue] Loop region length is not recalculated after tempo change [MU4 Issue] Loop region length is not recalculated after tempo change/tempo slider change Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority: Medium
Projects
Status: One of the next releases
4.x SHORTLIST
  
To do
[MU4 - MPE]
  
To do
Development

No branches or pull requests

4 participants