fixed updating the playback loop after changing the global tempo value

see: musescore#12803 (comment)
RomanPudashkin · Aug 15, 2022 · 2e59307 · 2e59307
1 parent 3c71ec7
commit 2e59307
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/playback/internal/playbackcontroller.cpp b/src/playback/internal/playbackcontroller.cpp
@@ -327,7 +327,7 @@ void PlaybackController::onNotationChanged()
  });
 
  notationPlayback()->loopBoundariesChanged().onNotify(this, [this]() {
- setLoop(notationPlayback()->loopBoundaries());
+ updateLoop();
  });
 
  m_notation->interaction()->selectionChanged().onNotify(this, [this]() {
@@ -345,7 +345,7 @@ void PlaybackController::onSelectionChanged()
 
  if (!isRangeSelection) {
  if (selectionTypeChanged) {
- setLoop(notationPlayback()->loopBoundaries());
+ updateLoop();
  updateMuteStates();
  }
 
@@ -577,12 +577,14 @@ void PlaybackController::addLoopBoundaryToTick(LoopBoundaryType type, int tick)
  }
 }
 
-void PlaybackController::setLoop(const LoopBoundaries& boundaries)
+void PlaybackController::updateLoop()
 {
- IF_ASSERT_FAILED(playback()) {
+ IF_ASSERT_FAILED(notationPlayback() && playback()) {
  return;
  }
 
+ const LoopBoundaries& boundaries = notationPlayback()->loopBoundaries();
+
  if (!boundaries.visible) {
  hideLoop();
  return;
@@ -1106,6 +1108,7 @@ void PlaybackController::setTempoMultiplier(double multiplier)
 
  playback->setTempoMultiplier(multiplier);
  seek(tick);
+ updateLoop();
 
  if (playing) {
  resume();

diff --git a/src/playback/internal/playbackcontroller.h b/src/playback/internal/playbackcontroller.h
@@ -142,8 +142,7 @@ class PlaybackController : public IPlaybackController, public actions::Actionabl
 
  void addLoopBoundary(notation::LoopBoundaryType type);
  void addLoopBoundaryToTick(notation::LoopBoundaryType type, int tick);
-
- void setLoop(const notation::LoopBoundaries& boundaries);
+ void updateLoop();
 
  void showLoop();
  void hideLoop();