[core] Clean error messages prefix #2676

flaviendelangle · 2021-09-23T14:17:58Z

m4theushw · 2021-09-23T14:30:56Z

Do you plan to also update the documentation?

oliviertassinari · 2021-09-23T16:53:06Z

In the issue description, I didn't try to provide a comprehensive list of the type of references that needs to be updated. I would encourage to do a global search for Material-UI and https://material-ui.com.

flaviendelangle · 2021-09-23T22:25:14Z

I can update this pr with the other cases yes

CONTRIBUTING.md

README.md

docs/README.md

docs/pages/api-docs/data-grid/data-grid-pro.md

oliviertassinari · 2021-09-27T15:32:22Z

docs/pages/api-docs/data-grid/data-grid-pro.md

@@ -132,7 +132,7 @@ You can use the [slots API](/components/data-grid/components/#overriding-compone

 | Name | Type | Default | Description |
 |:-----|:-----|:--------|:------------|
-| <span class="prop-name">Checkbox</span> | <span class="prop-type">elementType</span> | <span class="prop-type">Checkbox</span> | Checkbox component used in the grid for both header and cells. By default, it uses the Material-UI core Checkbox component. |
+| <span class="prop-name">Checkbox</span> | <span class="prop-type">elementType</span> | <span class="prop-type">Checkbox</span> | Checkbox component used in the grid for both header and cells. By default, it uses the MUI core Checkbox component. |


What is the difference between the two lines here ?

It was the same, oops, updated. I wondered about the capitalization of the MUI Core.

If we approved this one, could we update the whole codebase? I assume that the source of truth for this one is in the TypeScript' descriptions.

If we approved this one, could we update the whole codebase? I assume that the source of truth for this one is in the TypeScript' descriptions.

I think it's not worth to waste time updating the manually authored API pages now. The documentation for this component can be automatically generated in #2465. BTW, the TypeScript definition doesn't have the "By default, it uses the MUI..." part.

BTW, the TypeScript definition doesn't have the "By default, it uses the MUI..." part.

Oh nice, +1 for ignoring the api .md files and focusing on the TypeScript definition. It started to diverge on this instance with #1528.

Co-authored-by: Olivier Tassinari <[email protected]>

packages/grid/_modules_/grid/hooks/features/keyboard/useGridKeyboardNavigation.ts

packages/grid/_modules_/grid/hooks/root/useGridApiContext.ts

packages/grid/data-grid/LICENSE

packages/grid/data-grid/src/tests/components.DataGrid.test.tsx

packages/x-license/src/licenseErrorMessageUtils.ts

…yboardNavigation.ts Co-authored-by: Matheus Wichman <[email protected]>

Co-authored-by: Matheus Wichman <[email protected]>

…yboardNavigation.ts Co-authored-by: Matheus Wichman <[email protected]>

Co-authored-by: Matheus Wichman <[email protected]>

docs/pages/api-docs/data-grid/data-grid-pro.md

oliviertassinari · 2021-10-02T14:33:15Z

packages/grid/x-grid-data-generator/LICENSE

@@ -1,6 +1,6 @@
 MIT License

-Copyright (c) 2020 Material-UI SAS
+Copyright (c) 2021 Material-UI SAS


AFAIK, this change is not correct, see https://opensource.stackexchange.com/questions/6389/how-do-the-years-specified-in-a-copyright-statement-work for why. It's meant to signal the first year when the content was created.

@mbrookes A preference on what we should do? Like React or

Suggested change

Copyright (c) 2021 Material-UI SAS

Copyright (c) Material-UI SAS

or as before, the first year

Suggested change

Copyright (c) 2021 Material-UI SAS

Copyright (c) 2020 Material-UI SAS

or a range

Suggested change

Copyright (c) 2021 Material-UI SAS

Copyright (c) 2020-2021 Material-UI SAS

?

I would be leaning to revert, match what we do in the core.

Sorry, missed this. Consistent with the core makes sense.

One problem with the year of creation is that it doesn't strictly apply to source code that is changed over the years, unlike say a book which is published in a particular year, and doesn't change. That said, it doesn't much matter, as copyright is implicit, and by the time the copyright expires on the first commits, we'll be beyond caring. Not to mention, for open source, copyright doesn't hold much meaning.

oliviertassinari · 2021-10-02T14:43:52Z

docs/pages/playground.js

+import * as React from 'react';
+
+export default function Playground() {
+ return <div>This file is listed in `.gitignore`</div>;
+}


It would have been better as a tsx file, done in #2755.

[core] Clean error messages prefix

407fe29

flaviendelangle self-assigned this Sep 23, 2021

flaviendelangle requested a review from oliviertassinari September 23, 2021 14:18

flaviendelangle added 4 commits September 27, 2021 11:45

Rename Material => MUI everywhere

9e9938d

Prettier

2aecc97

Fix

decfe28

Docs

12d5bae

oliviertassinari reviewed Sep 27, 2021

View reviewed changes

flaviendelangle and others added 5 commits September 27, 2021 17:33

Update CONTRIBUTING.md

170e7d7

Co-authored-by: Olivier Tassinari <[email protected]>

Update docs/README.md

9b6d8af

Co-authored-by: Olivier Tassinari <[email protected]>

Update CONTRIBUTING.md

0b1eac4

Co-authored-by: Olivier Tassinari <[email protected]>

Update docs/pages/api-docs/data-grid/data-grid-pro.md

5efc083

Co-authored-by: Olivier Tassinari <[email protected]>

Update docs/README.md

1ef7ce5

Co-authored-by: Olivier Tassinari <[email protected]>

oliviertassinari added docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes labels Sep 27, 2021

flaviendelangle and others added 3 commits September 27, 2021 20:11

Update docs/pages/api-docs/data-grid/data-grid-pro.md

70070c6

Co-authored-by: Olivier Tassinari <[email protected]>

Merge

1813990

Fix

ea05ad3

m4theushw reviewed Sep 29, 2021

View reviewed changes

flaviendelangle and others added 6 commits September 29, 2021 15:13

Update packages/grid/_modules_/grid/hooks/features/keyboard/useGridKe…

1fd88f0

…yboardNavigation.ts Co-authored-by: Matheus Wichman <[email protected]>

Update packages/grid/_modules_/grid/hooks/root/useGridApiContext.ts

71b8cd3

Co-authored-by: Matheus Wichman <[email protected]>

Update packages/grid/_modules_/grid/hooks/features/keyboard/useGridKe…

996b8f5

…yboardNavigation.ts Co-authored-by: Matheus Wichman <[email protected]>

Update packages/grid/data-grid/src/tests/components.DataGrid.test.tsx

b57f25a

Co-authored-by: Matheus Wichman <[email protected]>

Update packages/x-license/src/licenseErrorMessageUtils.ts

03c6908

Co-authored-by: Matheus Wichman <[email protected]>

Fix

a3983eb

m4theushw reviewed Sep 29, 2021

View reviewed changes

docs/pages/api-docs/data-grid/data-grid-pro.md Outdated Show resolved Hide resolved

Code review

c8c84c3

m4theushw approved these changes Oct 1, 2021

View reviewed changes

flaviendelangle merged commit e3be5cf into mui:next Oct 1, 2021

flaviendelangle deleted the error-messages branch October 1, 2021 19:04

oliviertassinari reviewed Oct 2, 2021

View reviewed changes

oliviertassinari mentioned this pull request Nov 30, 2021

[core] Transition to a new StackOverflow tag mui/material-ui#29967

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Clean error messages prefix #2676

[core] Clean error messages prefix #2676

flaviendelangle commented Sep 23, 2021

m4theushw commented Sep 23, 2021

oliviertassinari commented Sep 23, 2021 •

edited

Loading

flaviendelangle commented Sep 23, 2021

oliviertassinari Sep 27, 2021 •

edited

Loading

flaviendelangle Sep 27, 2021

oliviertassinari Sep 27, 2021 •

edited

Loading

oliviertassinari Sep 27, 2021

m4theushw Sep 27, 2021 •

edited

Loading

oliviertassinari Sep 27, 2021

oliviertassinari Oct 2, 2021

mbrookes Oct 7, 2021

oliviertassinari Oct 2, 2021 •

edited

Loading

	\| <span class="prop-name">Checkbox</span> \| <span class="prop-type">elementType</span> \| <span class="prop-type">Checkbox</span> \| Checkbox component used in the grid for both header and cells. By default, it uses the MUI core Checkbox component. \|
	\| <span class="prop-name">Checkbox</span> \| <span class="prop-type">elementType</span> \| <span class="prop-type">Checkbox</span> \| Checkbox component used in the grid for both header and cells. By default, it uses the MUI Core Checkbox component. \|

	Copyright (c) 2021 Material-UI SAS
	Copyright (c) Material-UI SAS

	Copyright (c) 2021 Material-UI SAS
	Copyright (c) 2020 Material-UI SAS

	Copyright (c) 2021 Material-UI SAS
	Copyright (c) 2020-2021 Material-UI SAS

[core] Clean error messages prefix #2676

[core] Clean error messages prefix #2676

Conversation

flaviendelangle commented Sep 23, 2021

m4theushw commented Sep 23, 2021

oliviertassinari commented Sep 23, 2021 • edited Loading

flaviendelangle commented Sep 23, 2021

oliviertassinari Sep 27, 2021 • edited Loading

Choose a reason for hiding this comment

flaviendelangle Sep 27, 2021

Choose a reason for hiding this comment

oliviertassinari Sep 27, 2021 • edited Loading

Choose a reason for hiding this comment

oliviertassinari Sep 27, 2021

Choose a reason for hiding this comment

m4theushw Sep 27, 2021 • edited Loading

Choose a reason for hiding this comment

oliviertassinari Sep 27, 2021

Choose a reason for hiding this comment

oliviertassinari Oct 2, 2021

Choose a reason for hiding this comment

mbrookes Oct 7, 2021

Choose a reason for hiding this comment

oliviertassinari Oct 2, 2021 • edited Loading

Choose a reason for hiding this comment

oliviertassinari commented Sep 23, 2021 •

edited

Loading

oliviertassinari Sep 27, 2021 •

edited

Loading

oliviertassinari Sep 27, 2021 •

edited

Loading

m4theushw Sep 27, 2021 •

edited

Loading

oliviertassinari Oct 2, 2021 •

edited

Loading