Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material-UI -> MUI renaming in the codebase #2631

Closed
oliviertassinari opened this issue Sep 17, 2021 · 1 comment · Fixed by #2676
Closed

Material-UI -> MUI renaming in the codebase #2631

oliviertassinari opened this issue Sep 17, 2021 · 1 comment · Fixed by #2676
Assignees
@flaviendelangle
Labels
docs Improvements or additions to the documentation

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 17, 2021 •
edited
Loading

There are multiple instances where we can rename the new project's name

https://github.com/mui-org/material-ui-x/blob/e9a9ecc3bf932d38c8a1cf5edbd1abc8eb3de11d/packages/grid/data-grid/src/DataGrid.tsx#L88

https://github.com/mui-org/material-ui-x/blob/e9a9ecc3bf932d38c8a1cf5edbd1abc8eb3de11d/packages/grid/data-grid/package.json#L13
@oliviertassinari oliviertassinari changed the title Material-UI -> MUI renaming in the codebase. Material-UI -> MUI renaming in the codebase Sep 17, 2021
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Sep 17, 2021
@flaviendelangle
Copy link
Member

flaviendelangle commented Sep 17, 2021 •
edited
Loading

For the error messages, I'll do a PR adding / renaming the Material-UI prefix on everyone of them.
Some do not have Material-UI at all

@flaviendelangle flaviendelangle mentioned this issue Sep 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaviendelangle flaviendelangle

Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] Clean error messages prefix flaviendelangle/mui-x
2 participants
@oliviertassinari @flaviendelangle