[test] Add yarn t support #1385
Conversation
25ac596
to
a6e4303
Compare
| @@ -19,6 +19,7 @@ | |||
| "prettier:all": "node ./scripts/prettier.js write", | |||
| "size:snapshot": "node --max-old-space-size=2048 ./scripts/sizeSnapshot/create", | |||
| "size:why": "yarn size:snapshot --analyze --accurateBundles", | |||
| "t": "node test/cli.js", | |||
There was a problem hiding this comment.
What does t do? Can we rename?
There was a problem hiding this comment.
This is described in the pull request description: mui/material-ui#23369. It's meant to bring some of the jest capabilities around only running a subset of the tests and fast.
There was a problem hiding this comment.
@eps1lon Maybe we should document yarn t in https://github.com/mui-org/material-ui/blob/next/test/README.md#commands?
There was a problem hiding this comment.
Since this command is experimental and I haven't received any feedback, I'm hesitant to document it.
There was a problem hiding this comment.
What would be the criteria for promoting the command from the experimental state to a stable one?
(When it comes to running tests in jsdom, I'm personally almost exclusively using yarn t over yarn test:watch).
|
I'm closing. I have explored the feasibility of bringing this tool here. It has surfaced a structural issue. I'm surprised yarn t is still considered experimental. It has become my default test runner. It would be interesting to ask the other members of the team what they use. |
This is a follow-up of #1361. I'm trying to bring mui/material-ui#23369 to this repository. However, I'm facing a blocker with this line:
const workspaceRoot = path.resolve(__dirname, '../');. It doesn't resolve to the correct root of this repository.For prettier, we could get it working with this workaround:
const workspaceRoot = process.cwd();@eps1lon do you have a preference on the solution we take this time?