-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Run more tests in jsdom #1361
Merged
oliviertassinari
merged 19 commits into
mui:master
from
oliviertassinari:react-testing-library
Apr 26, 2021
Merged
[test] Run more tests in jsdom #1361
oliviertassinari
merged 19 commits into
mui:master
from
oliviertassinari:react-testing-library
Apr 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
react-testing-library
branch
4 times, most recently
from
April 4, 2021 23:43
f39a567
to
935e1df
Compare
dtassone
reviewed
Apr 6, 2021
oliviertassinari
force-pushed
the
react-testing-library
branch
from
April 10, 2021 21:31
c2de724
to
fdf8b15
Compare
2 tasks
oliviertassinari
force-pushed
the
react-testing-library
branch
from
April 10, 2021 21:56
d30fdc1
to
79a0302
Compare
This was referenced Apr 10, 2021
dtassone
reviewed
Apr 12, 2021
dtassone
reviewed
Apr 12, 2021
oliviertassinari
force-pushed
the
react-testing-library
branch
from
April 13, 2021 13:36
6523c35
to
40c6bee
Compare
I have rebased on HEAD. |
dtassone
reviewed
Apr 13, 2021
packages/grid/_modules_/grid/hooks/features/virtualization/useGridVirtualRows.ts
Show resolved
Hide resolved
oliviertassinari
force-pushed
the
react-testing-library
branch
from
April 19, 2021 00:01
75046a2
to
a6b14f4
Compare
dtassone
reviewed
Apr 19, 2021
dtassone
reviewed
Apr 19, 2021
dtassone
reviewed
Apr 19, 2021
oliviertassinari
force-pushed
the
react-testing-library
branch
from
April 24, 2021 14:45
35357fa
to
f67f366
Compare
@dtassone Ok, done. Please review. This is solving most of the pain in #1151. Regarding closing #1151, maybe what would be left is to add coverage for it in the documentation, maybe in this section: https://material-ui.com/components/data-grid/virtualization/. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on #1151:
We go from 2% of coverage
to 69% of coverage
for tests running in jsdom.
Two issues I didn't spend time on here. I'm breaking them down into two new PRs.
I wouldn't be surprised if this impacts developers in their project too. Not great
yarn t xxxx
script to only run a specific test, really fast. It would be great to bring it here. [test] Add yarn t support #1385