Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewer/editor Initial fix for warning when viewing big jpg #1217, vie… #1219

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

pskowronek
Copy link
Member

Initial fix for warning when viewing big images #1217 plus viewer/editor unification/refactor

@hajdam
Copy link
Collaborator

hajdam commented Jun 21, 2024

Hi, I think there were some discussion about this few years back. I don't mind this fix, just few notes:

  • Maybe better to avoid "File Open" terminology as there is different concept for opening files in muCommander and stick with "File Viewing"
  • My vote still goes to remove showing pop-up dialog altogether and instead just show warning / continue button in viewer itself

@pskowronek
Copy link
Member Author

  • Maybe better to avoid "File Open" terminology as there is different concept for opening files in muCommander and stick with "File Viewing"

'FileOpen' is for me intuitive (especially that it is under viewer packager. I'm open to rename it, since I don't have better name :) if anyone is able to suggest sth nicer then please.

  • My vote still goes to remove showing pop-up dialog altogether and instead just show warning / continue button in viewer itself

Yeah, in another PR I could change that, plus move the msg box somewhere else in the code.

package/readme.txt Outdated Show resolved Hide resolved
@ahadas ahadas merged commit 75e3e44 into mucommander:master Jun 27, 2024
2 checks passed
@ahadas ahadas linked an issue Jun 27, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Image Preview [F3] complains about too large file
3 participants