Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Image Preview [F3] complains about too large file #1217

Closed
1 task done
pskowronek opened this issue Jun 16, 2024 · 0 comments · Fixed by #1219
Closed
1 task done

[Bug] Image Preview [F3] complains about too large file #1217

pskowronek opened this issue Jun 16, 2024 · 0 comments · Fixed by #1219
Assignees
@pskowronek
Labels
bug
Milestone
1.5.0

Comments

@pskowronek
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues (including the closed ones)

Description

Image Preview [F3] complains about too large file

Steps to reproduce

  • Navigate to JPEG file having ~10MB or more
  • try to hit F3 (Preview)

Expected behavior

  • image preview is rendered without showing a message box that file is too large

Actual behavior

  • Message box appears that file is too large (probably the same one as if it was text file too large) - see screenshot
  • Another problem is that even if one clicks Cancel, the preview is still shown (probably the behavior originates from text files when Binary Viewer is used in such a case).

Screenshots?

obraz

muCommander version

1.4.1

Java version

23-internal
OpenJDK 64-Bit Server VM
23-internal-ahadas-0081ac197a656cdc0d88d5a5e2a0f399ee023654
Oracle Corporation

Operating System type and version

Mac OS X
13.6.7
x86_64

Relevant log output

N/A
@pskowronek pskowronek added the bug label Jun 16, 2024
@pskowronek pskowronek self-assigned this Jun 19, 2024
pskowronek added a commit to pskowronek/mucommander-for-pr that referenced this issue Jun 19, 2024
@pskowronek
viewer/editor Initial fix for warning when viewing big jpg mucommande…
0c581a0 
…r#1217, viewer/editor unification/refactor
@pskowronek pskowronek mentioned this issue Jun 19, 2024
Merged
pskowronek added a commit to pskowronek/mucommander-for-pr that referenced this issue Jun 24, 2024
@pskowronek
viewer/editor Initial fix for warning when viewing big jpg mucommande…
81c29b3 
…r#1217 - update readme
@ahadas ahadas added this to the 1.5.0 milestone Jun 26, 2024
pskowronek added a commit to pskowronek/mucommander-for-pr that referenced this issue Jun 26, 2024
@pskowronek
viewer/editor Initial fix for warning when viewing big jpg mucommande…
7d3fd3d 
…r#1217 - updated readme after PR review
ahadas pushed a commit that referenced this issue Jun 27, 2024
@pskowronek @ahadas
viewer/editor Initial fix for warning when viewing big jpg #1217, vie…
402909e 
…wer/editor unification/refactor
ahadas pushed a commit that referenced this issue Jun 27, 2024
@pskowronek @ahadas
viewer/editor Initial fix for warning when viewing big jpg #1217 - up…
2f7d319 
…date readme
ahadas pushed a commit that referenced this issue Jun 27, 2024
@pskowronek @ahadas
viewer/editor Initial fix for warning when viewing big jpg #1217 - up…
75e3e44 
…dated readme after PR review
@ahadas ahadas linked a pull request Jun 27, 2024 that will close this issue
viewer/editor Initial fix for warning when viewing big jpg #1217, vie… #1219
Merged
@ahadas ahadas closed this as completed Jun 27, 2024
pskowronek added a commit to pskowronek/mucommander-for-pr that referenced this issue Jun 29, 2024
@pskowronek
image viewer - file too large message box moved to Presenter mucomman…
e893edc 
…der#1217
@pskowronek pskowronek mentioned this issue Jun 29, 2024
Merged
ahadas pushed a commit that referenced this issue Jun 30, 2024
@pskowronek @ahadas
image viewer - file too large message box moved to Presenter #1217
c58c4c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pskowronek pskowronek

Labels
bug
Projects
None yet
Milestone
1.5.0
2 participants
@pskowronek @ahadas