Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleach breaks with latest html5lib release #337

Closed
rixx opened this issue Dec 7, 2017 · 1 comment
Closed

Bleach breaks with latest html5lib release #337

rixx opened this issue Dec 7, 2017 · 1 comment

Comments

@rixx
Copy link

rixx commented Dec 7, 2017

Upgrading to html5lib-1.0.1 breaks, as they made their ReparseException class private as per html5lib/html5lib-python#371. This breaks bleach on import:

  File "/home/rixx/Projects/chaos/pretalx/src/pretalx/mail/models.py", line 3, in <module>
    import bleach
  File "/home/rixx/.virtualenvs/pretalx/lib/python3.6/site-packages/bleach/__init__.py", line 11, in <module>
    from bleach.sanitizer import (
  File "/home/rixx/.virtualenvs/pretalx/lib/python3.6/site-packages/bleach/sanitizer.py", line 10, in <module>
    from html5lib.constants import (
ImportError: cannot import name 'ReparseException'

bleach is also at its latest version. For all concerned: pinning html5lib to html5lib==1.0b10 resolves the issue until a new (fixed) bleach release is out there, or manually install it with pip install html5lib==1.0b10.

@willkg
Copy link
Member

willkg commented Dec 7, 2017

We just did the html5lib-python release. I'll fix Bleach to work with html5lib-python 1.0 today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants