Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make html5lib.constants.ReparseException private #371

Closed
willkg opened this issue Nov 29, 2017 · 1 comment
Closed

make html5lib.constants.ReparseException private #371

willkg opened this issue Nov 29, 2017 · 1 comment
Milestone
1.0

Comments

@willkg
Copy link
Contributor

willkg commented Nov 29, 2017

The ReparseException isn't intended to be used by anyone else--it's for internal use only. Given that, the name should start with a _.

This issue covers changing that and any code that uses it.
@willkg willkg added this to the 1.0 milestone Nov 29, 2017
@willkg
Copy link
Contributor Author

willkg commented Nov 29, 2017

Pretty sure this is a straight-forward change someone could make for 1.0.

@willkg willkg mentioned this issue Nov 29, 2017
Merged
@rixx rixx mentioned this issue Dec 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@willkg