Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add giscus support #3022

Merged
merged 21 commits into from
Jul 5, 2021
Merged

Add giscus support #3022

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a7534a6
Add script in same style as utterances
SeanKilleen Jun 26, 2021
c9330c7
Add initial script
SeanKilleen Jun 26, 2021
b0d5b1e
Add default settings
SeanKilleen Jun 26, 2021
3348c57
Update changelog
SeanKilleen Jun 26, 2021
31b83b9
Add feature to readme
SeanKilleen Jun 26, 2021
c6bccbd
Add comments html
SeanKilleen Jun 26, 2021
f8844d7
add comment provider include
SeanKilleen Jun 26, 2021
481f36f
update config in docs
SeanKilleen Jun 26, 2021
c25025e
Add URL for additional reference
SeanKilleen Jun 26, 2021
2108f6b
docs for giscus comments
SeanKilleen Jun 26, 2021
55d925a
Unrelated bugfix: add missing version separator
SeanKilleen Jun 26, 2021
e6a042e
add space
SeanKilleen Jun 26, 2021
2dae4a9
update history doc
SeanKilleen Jun 26, 2021
50874cf
update about doc
SeanKilleen Jun 26, 2021
80c1db4
add to test config yaml
SeanKilleen Jun 26, 2021
5e8f92d
remove unnecessary / incorrect async attribute
SeanKilleen Jun 26, 2021
655abdd
probably should pass the right config paths
SeanKilleen Jun 26, 2021
5a04d58
lowercase the repo name
SeanKilleen Jun 27, 2021
5fe9ae0
Update docs to address '1' and '0' for reactions_enabled
SeanKilleen Jun 27, 2021
807c816
update two additional docs
SeanKilleen Jun 27, 2021
0a7b730
docs wording fix
SeanKilleen Jul 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add initial script
  • Loading branch information
@SeanKilleen
SeanKilleen committed Jun 26, 2021
commit c9330c7ade190636af2af708f144ebb86aa88f95
2 changes: 1 addition & 1 deletion _includes/comments-providers/giscus.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
script.setAttribute('data-repo-id', '{{ site.giscus.repo_id }}');
script.setAttribute('data-category', '{{ site.giscus.category_name }}');
script.setAttribute('data-category-id', '{{ site.giscus.category_id }}');
script.setAttribute('data-mapping', '{{ site.comments.giscus.issue_term | default: "pathname" }}');
script.setAttribute('data-mapping', '{{ site.comments.giscus.discussion_term | default: "pathname" }}');
script.setAttribute('data-reactions-enabled', '{{ site.comments.giscus.reactions_enabled | default: 1 }}'); // TODO: Convert from boolean
script.setAttribute('data-theme', '{{ site.comments.giscus.theme | default: "light" }}');
script.setAttribute('crossorigin', 'anonymous');
Expand Down