Add giscus support #3022

SeanKilleen · 2021-06-26T15:01:44Z

This is an enhancement or feature.

Summary

Adds support for giscus for comments.

Context

Giscus (https://giscus.app/) is similar to utterances (which is currently supported). The key difference is that giscus uses GitHub discussions rather than GitHub issues. This is preferable to me, so I figured I would contribute this support.

How to Test

Authorize the Giscus app for a repo at the link at https://Giscus.app
enable discussions and Set up a discussion category on the repository where giscus is authorized
Use https://giscus.app to get the config values.
Update the _config.yml in my branch to enable giscus (also set the repository)
Run it locally
From a comment enabled post, post a comment to the category.

But adjusted for the various filed differences

So that things match the "history" doc.

SeanKilleen · 2021-06-26T15:29:49Z

OK, I think at this point I've made all the required updates. On to testing it and tweaking it. My next intentions are to:

Set up a discussion category on my repository where giscus is authorized
Update the config.yml in my branch to enable giscus and set the repository etc.
Run it locally
See if I can post a comment to the category.

SeanKilleen · 2021-06-26T15:56:11Z

Hmm, for some reason I can't get the comments to show when updating _config.yml in both the base and test directories and running bundle exec rake preview. I'll dig into it. I'm sure I'm doing something wrong.

mmistakes · 2021-06-26T16:03:26Z

Comments are disabled by default in development. To enable when testing/building locally be sure to set JEKYLL_ENV=production to force the environment to production.

SeanKilleen · 2021-06-26T16:10:51Z

@mmistakes ah, thank you! That's almost certainly it. Had to step away but I'll check this ASAP.

SeanKilleen · 2021-06-26T17:02:57Z

Update --

✅ UI now shows
✅ I can login with my GitHub Account
✅ I can post to start a discussion
⚠️ Something is going wrong where the tool doesn't realize a discussion has been created, so creates many new discussions rather than appending to the existing one. This happens across refreshes.

SeanKilleen · 2021-06-27T01:00:34Z

Resolved the issue, which was with Giscus itself. The issue is one around ensuring that the repository name is all lower-case, because it uses the GitHub repo and the expectation there is all lower-case, I believe.

I'll put a PR in over there, but in the interim I'll lowercase it in the include file so it works.

SeanKilleen · 2021-06-27T01:15:46Z

Alright @mmistakes, I think this is ready for review:

View of an existing comment on the test post:

Signing into GitHub after clicking on the button:

Add comments:

Discussion thread where we can see the comments being posted: SeanKilleen/seankilleen.github.io#601

SeanKilleen · 2021-06-27T01:18:59Z

CHANGELOG.md

@@ -11,6 +11,9 @@
 - Remove `h2` from skip links navigation as it is not important for site structure. [#3012](https://github.com/mmistakes/minimal-mistakes/pull/3012)
 - Loads Font Awesome asynchronously. [#2967](https://github.com/mmistakes/minimal-mistakes/pull/2967)
 - Replace custom search icon SVG with Font Awesome icon. [#2774](https://github.com/mmistakes/minimal-mistakes/pull/2774)
+- Adds support for giscus comments. [#3022](https://github.com/mmistakes/minimal-mistakes/pull/3022)
+
+## [4.23.0](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.23.0)


ℹ️ FYI, I added this because it was missing according to the other document. Figured I'd fix it here but if you'd like it as a separate PR I'm happy to do so.

Figured I'd match the giscus format rather than convert a boolean to an int there.

SeanKilleen · 2021-06-29T12:24:22Z

@mmistakes I added some instructions for how to verify the PR to the description. Let me know if you need anything else to assist with review of this; otherwise I'll assume it's in your hands until you get some time for it. 👍 Thanks!

mmistakes · 2021-07-05T19:47:54Z

docs/_docs/05-configuration.md

+
+To use giscus you will need to [install the app](https://github.com/apps/giscus) to your GitHub repository.
+
+The next step is to go to <https://giscus.app> and fill out the desired settings. This will generate a javascript, which will provide you with some of the settings you will need to configure things below.


Fix captialization to stay consist with rest of theme docs, e.g. JavaScript. Might read better as "This will generate JavaScript" as "a JavaScript" sounds weird to me.

mmistakes

Small doc change. Implimentation looks fine to me. I didn't test it as I don't really want to pollute this repo with discussion comments so I'll take your word that it works.

If it doesn't I'm sure someone will let us know ;-)

SeanKilleen · 2021-07-05T19:52:31Z

@mmistakes sure thing 👍 fix coming shortly. I think I just copied/pasted from the utterances docs to start; if so I'll clean that up too real quick.

SeanKilleen · 2021-07-05T19:56:45Z

@mmistakes ready to go 👍

* Add script in same style as utterances But adjusted for the various filed differences * Add initial script * Add default settings * Update changelog * Add feature to readme * Add comments html * add comment provider include * update config in docs * Add URL for additional reference * docs for giscus comments * Unrelated bugfix: add missing version separator So that things match the "history" doc. * add space * update history doc * update about doc * add to test config yaml * remove unnecessary / incorrect async attribute * probably should pass the right config paths * lowercase the repo name * Update docs to address '1' and '0' for reactions_enabled Figured I'd match the giscus format rather than convert a boolean to an int there. * update two additional docs * docs wording fix

@iBug

* Change tab indent to space for consistency (mmistakes#2614) * Fix link for author name (mmistakes#2575) Missed from bcd6126 * Update CHANGELOG and history * Update zh-cn (mmistakes#2576) * Update zh-cn * Update ui-text.yml * Update CHANGELOG and history * Use layout: none instead of null (mmistakes#2617) * Use layout: none instead of null * Update CHANGELOG and history * Configure entries layout `list` or `grid` (mmistakes#2616) * Configure entries layout `list` or `grid` This allows to use grid layout on `page.entries_layout` on the home layout. Included a break since when using grid the post images are too close to the horizontal line bellow `posts` text. There's a entries div now surrounding the posts since the first row of the grid was having a slight padding on the left. The home now behaves like posts/categories/tags pages with grid but including the paginator. For best results on desktop use `classes: wide` and `paginate: 4` on `_config.yml` (or multiples of 4 if you want more rows) * Fix indent * Archive subtitle leaves space on the bottom * Now space is added through style * Update CHANGELOG and history * Include documentation for home page grid view * Update 10-layouts.md * Update UI text for zh-CN and zh-TW (mmistakes#2626) * Update UI text for zh-CN and zh-TW * Update CHANGELOG and history Not touching last_modified_at this time - it's messy enough * Update documentation for mmistakes#2621 (mmistakes#2624) * Update documentation for mmistakes#2621 * Update CHANGELOG and history * Update last_modified_at * remove hidden posts from `/posts` (mmistakes#2625) * Update CHANGELOG and history * Show date of posts (mmistakes#2526) * add date to read-time.html * add option for show_date, dynamic icon style * change read-time to post__meta * cleanup post__metal.html * cleanup post__meta include variables * put date before read time * remove space in include variable * allow customisation of post__meta separator * add some documentation * oops fix typo derp * add post date image * change page meta separator customisation to CSS * Update CHANGELOG and history * Fix grammar * Remove extra back ticks * Release 4.20.0 💎 * Update remote_theme * Fix grammar * Fix grid `entries_layout` in home.html * Release 4.20.1 💎 * Update remote_theme version * Fix `entries_layout: grid` Close mmistakes#2639 * Update CHANGELOG and history * Change "fa" to "fas" for Font Awesome 5 (mmistakes#2649) * main.js: fa -> fas for FA 5 * Update CHANGELOG and history * added css changes, modified jquery.greedy-navigation and built the main.min.js again * Removed duplicated CSS definitions (mmistakes#2666) * Update CHANGELOG and history * Added article:author used by Pinterest (mmistakes#2670) * Update CHANGELOG and history * Refactor page meta (mmistakes#2641) * Rename include * Add grid view test pages * Rename `.post__meta-sep` and use CSS to add line break * Improve collection grid archive * Improve page grid archive * Enable `grid` * Don't show date icon if there is no `date` value * Add blank line at EOF * Add space * Wrap date and reading time in named `span` elements * Update CHANGELOG and history * Bump copyright year * Fix typo Close mmistakes#2678 * Fix broken link in documentation Close mmistakes#2677 * Release 4.20.2 💎 * Bump theme version * Update allejo/jekyll-toc to v1.0.14 https://github.com/allejo/jekyll-toc/releases/tag/v1.0.14 * Fix dead link to "CI services" Jekyll (mmistakes#2692) * Fix mmistakes#2635 * Update CHANGELOG and history * Update README.md * Update CONTRIBUTING.md * Update stale.yml * Fix closing tag of figures without captions in lists (mmistakes#2697) When the figure helper is used in a list, which can be either ordered or unordered, and no caption is specified, a line with text "</figure>" will be shown below the figure on the rendered page. This is because, if the '{% if include.caption %}' evaluates to false, the lines between that 'if' statement and '{% endif %}' will be emptied, not removed, so the block will be filled by empty lines. HTML ignores redundant empty lines, but Markdown takes them seriously. In addition, Markdown expects proper indentation of lines inside lists, and the closing '</figure>' tag is not indented. When combined, the empty space and absence of indentation cause Markdown to process the '</figure>' tag as a separate paragraph instead of an HTML tag, thus the text for the tag is directly rendered on the page. The fix for this issue is very simple: remove the empty space when 'include.caption' is false. As described in <https://shopify.github.io/liquid/basics/whitespace/>, this can be done by adding hyphens to the 'if' and 'endif' tags. * Update CHANGELOG and history * Update CHANGELOG and history * Norwegian translation (mmistakes#2702) * Update CHANGELOG and history * Update CHANGELOG and history * Fix a small typo in documentation * Update ui-text.yml for Vietnamese * Added some translation for indonesian language * Update indonesian translation * Update CHANGELOG and history * Update CHANGELOG and history * Update jQuery to 3.5.1 (mmistakes#2713) * Update jQuery to 3.5.1 Closes mmistakes#2712 * Build NodeJS Run using `npm run build:js` * Update CHANGELOG and history * Release 4.21.0 💎 * Update `remote_theme` version * Fix heading level * Fix Font Awesome icon color in various skins Close mmistakes#2724 * Update remote theme instructions * jekyll-install-cache gem should be added to Gemfile * Update CHANGELOG and history * indonesian translation minor typo fix (mmistakes#2731) * Update CHANGELOG and history * Update 404.md (mmistakes#2737) Removed Google Search script which no longer worked. mmistakes#2597 * Update CHANGELOG and history * Delete support.md * Delete feature_request.md * Update allejo/jekyll-toc to v1.1.0, skip headings without an ID (mmistakes#2752) * Update allejo/jekyll-toc to v1.1.0, skip headings without an ID https://github.com/allejo/jekyll-toc/releases/tag/v1.1.0 * Update CHANGELOG and history * Add toc_sticky parameter's description (mmistakes#2741) * Update CHANGELOG and history * Fix typo * Add hebrew translation (mmistakes#2760) * Update CHANGELOG and history * Add .webp to supported lightbox images (mmistakes#2788) * Update CHANGELOG and history * Remove google's fixurl.js from example (mmistakes#2789) Unfortunately, it no longer exists. * Update CHANGELOG and history * Upgrade Lunrjs to 2.3.9 and switch to relative_url (mmistakes#2805) * Update Lunr to 2.3.9 * Switch from absolute_url to relative_url * Update CHANGELOG and history * Allow custom gradient in page header overlays (mmistakes#2806) * Allow custom gradient in page header overlays * Update documentation * Update CHANGELOG and history * Add toggle option for RSS feed visibility (mmistakes#2787) * add a "hide" value in config for atom * Update footer to use param * update header to use param * Update docs to note configuration * undo formatting * use unless syntax * unless syntax and indentation * indentation * Update CHANGELOG and history * Use sort_natural instead of custom-logic (mmistakes#2756) * Update CHANGELOG and history * Allow custom sorting for collections (mmistakes#2723) * Allow custom sorting for collections * Update docs with custom sort of collections * Refactoring * Update CHANGELOG and history * Release 4.22.0 💎 * Update * Force rebuild of demo site * Fix typos * Remove G-stuff CSS (mmistakes#2852) (mmistakes#2855) * Add alt attr to site logo in masthead (mmistakes#2824) Co-authored-by: Michael Rose <[email protected]> * Add note on TOC heading level issue (mmistakes#2902) mmistakes#2892 (comment) * Add Baidu site verfication (mmistakes#2830) * Update CHANGELOG and history * Remove all references to official public Staticman API instance. (mmistakes#2831) * Updated Staticman docs * remove any ref to official public instance in docs * remove fallback instance for staticman v2 left staticman v1 untouched as I dunno how to deal with that * Update CHANGELOG and history * Datetime format (mmistakes#2844) * datetime_format * page__meta * page__date * page__date test * update docs * update docs * Update CHANGELOG and history * Color notices based on skin colors instead of fixed values (mmistakes#2887) * Made notice Sass color mixing in based on $background-color and $text-color instead of hard-coded black and white values. * Made some style adjustments to notices to improve readability. Notice links are slightly darkened from the notice color, mostly because the gray-on-gray default notice links were very hard to read. Rather than being $notice-color, they are `mix(#000, $notice-color, 10%)`. The notice background mix and code-background mix can now be set with the SCSS variables $notice-background-mix and $code-notice-background-mix. The default mix for background was adjusted to 80%, from 90%. The default mix for code-background was adjusted to 90%, from 95%. Skins that still didn't read well were adjusted individually. * Adjusted sunrise $notice-background-mix to 75% * Adjusted dark theme notice background mix colors back to the default Co-authored-by: Tom Manner <[email protected]> * Update CHANGELOG and history * Document user custom element hooks (mmistakes#2815) * Added documentation for including custom CSS on a site or page * Removed non-configuration related content from 05-configuration.md and cleaned up some style in new sections of 16-stylesheets.md * Moved small custom head documentation to a ProTip in _docs/06-overriding-theme-defaults.md * Cleaned up some documentation, and added some example uses of custom head and footer. * Replace double space with single * Replace double spaces with single Co-authored-by: Tom Manner <[email protected]> Co-authored-by: Michael Rose <[email protected]> * Update CHANGELOG and history * Add Arabic Translation 📝 * Update onchange and uglify-js dependencies * Fix typo * Update * Update 14-helpers.md (mmistakes#2940) Fix missing backtick. * Update CHANGELOG and history * Fix Jekyll environment note in configuration documentation Close mmistakes#2912 * Fix typo Close mmistakes#2911 * Update stale action * Update stale.yml * FIx menu toggle ref: mmistakes#2957 * Release 4.23.0 💎 * Update CHANGELOG and history * Bump theme version * Enable auto ads * Update Google Adsense * Update FUNDING.yml * Update FUNDING.yml * Update README.md * Disable auto ads * Update support buttons * Update Adsense * Add banner above related posts * Update FUNDING.yml * Update FUNDING.yml * Fix broken image Close mmistakes#3013 * feat: Search icon in masthead is a Font Awesome icon. (mmistakes#2774) * feat: Allow search icon in masthead to be set to a Font Awesome icon. * fix indentations * Users wishing to avoid FontAwesome should override _includes/masthead.html * Update CHANGELOG and history * Loads font-awesome asynchronously (mmistakes#2967) Loading font-awesome asynchronously allows to display the site faster. This change is advised by google pagespeed insights * Update CHANGELOG and history * Remove H2 as it is not important to site structure (mmistakes#3012) This should not use a H2, as that is not an important headline, and thus a H2 here would probably hurt in page SEO. * Update CHANGELOG and history * Fix broken links in documentation Close mmistakes#3004 * Remove `tabindex="-1"` from `input` elements in `search.html` layout Make `input` elements accessible by keyboard. Fixes mmistakes#2982 * Update README text for Gumshoejs license (mmistakes#3024) * Update CHANGELOG and history * Remove IE9 flexbox fallback (mmistakes#3042) IE9 is absolutely, completely, totally dead. it's marketshare is less than 0.1%. REF: https://caniuse.com/usage-table Save some bytes in the HTML for all users by removing the fallback inline CSS. * Update CHANGELOG and history * Add giscus support (mmistakes#3022) * Add script in same style as utterances But adjusted for the various filed differences * Add initial script * Add default settings * Update changelog * Add feature to readme * Add comments html * add comment provider include * update config in docs * Add URL for additional reference * docs for giscus comments * Unrelated bugfix: add missing version separator So that things match the "history" doc. * add space * update history doc * update about doc * add to test config yaml * remove unnecessary / incorrect async attribute * probably should pass the right config paths * lowercase the repo name * Update docs to address '1' and '0' for reactions_enabled Figured I'd match the giscus format rather than convert a boolean to an int there. * update two additional docs * docs wording fix * Release 4.24.0 💎 * Update version * Remove site.url from first breadcrumb link (mmistakes#3051) * Remove site.url from first breadcrumb link Fixes mmistakes#3050 * Use relative_rul filter instead of site.baseurl * Update CHANGELOG and history * Fixed a grammar error in the german translation (mmistakes#3063) * Update CHANGELOG and history * fix: change heading tag of related posts section from `h4` to `h2` for SEO enhancement (mmistakes#3064) * Update heading tag from `h4` to `h2` * Update heading tag from `h4` to `h2` * Update CHANGELOG and history * Add instructions on how to unminify main.js for easier browser debugging (mmistakes#3055) * Add instructions on how to unminify main.js for easier browser debugging * Fixed Markdown style like sggested by @iBug * Update CHANGELOG and history * Make small grammar changes * Update 01-quick-start-guide.md * Add Microformats (mmistakes#3052) * Add rel=me to author profile links * Add h-card Microformats markup * Add h-entry microformat markup * Fix missing anchor tag * Fix h-entry microformat markup on single template * Use minimal subset of Microformat elements * Move dt-published to `page__date.html` and remove dt-updated * Remove "author" and "summary" Leaves "url" as a hidden element * Add page link to h1 tag The h1 tag now contains the Schema-org `url` itemprop and the Microformats `url` class in an anchor tag. The anchor tag is styled to not look like a link. * Put author 'u-url' on author__name h3 This also puts the same `{{ author.home | default: '/' | absolute_url }}` construct on `author__avatar` to remove the Jekyll `author.home` conditional. Also addresses SCSS text color error. * Update CHANGELOG and history * Enable toc sidebar scrolling (mmistakes#2874) * Enable toc sidebar scrolling * Refactor style rules * Move style rules from 'navigation' to 'sidebar' * Remove custom scrollbar styles * Enable sticky toc on test post * Update CHANGELOG and history * Add margin around Google ads * Add role to search (mmistakes#3086) * Update CHANGELOG and history * Added Danish translations (mmistakes#3095) * Added Danish translations * Fixed wrong commit. * Update CHANGELOG and history * Enable magnific popup on <a> tags only when it has <img> (mmistakes#3114) * Update CHANGELOG and history * Remove extra semi-colon * Bump path-parse from 1.0.6 to 1.0.7 Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Update CHANGELOG and history * include video does not survive compress.html (mmistakes#3117) * Update CHANGELOG and history * Use GitHub issue templates (mmistakes#3133) https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository * Delete stale.yml * Delete stale.yml * Added optional label attribute (mmistakes#3128) Added label attribute as per utterances optional label setting. * Fix broken link & Add Baidu site verification (mmistakes#3139) * Fix broken link Link to Bing Webmaster Tools was broken. * Fix broken link Link to Open Graph debug tool was broken. * Add Baidu site verification (mmistakes#2830) Added `baidu_site_verification` to `_config.yml` * Making verbiage consistent w/current _config.yml (mmistakes#3180) The plugin in question comes by-default listed in _config.yml ; it's better to say that the user must _retain_ it as listed, not that the user needs to add it. * Link clarifying adding plugins (mmistakes#3181) The phrase "put them here!" doesn't sufficiently clarify what to do; I add link to the Jekyll documentation with the proper syntax. * feat: Sort comments by date ascending (mmistakes#3184) * Update Brazilian Portuguese translation (mmistakes#3204) * Update Brazilian Portuguese translation * Revert some translations to reduce friction * Update CHANGELOG and history * Update CHANGELOG and history * Fix keybase class (mmistakes#3221) * Fix keybase class * Fix fas->fab * Update CHANGELOG and history * ✏ fix typo (mmistakes#3232) * Update CHANGELOG and history * Add missing comma (mmistakes#3318) Co-authored-by: Yuchen Zhong <[email protected]> * Update CHANGELOG and history * Automatically close invalid PRs using GitHub Actions (mmistakes#3313) * Try auto-closing bad PRs * Include empty PR body as well * Add "Type: Invalid" label as well * Update CHANGELOG and history * Added sameAs (mmistakes#3087) * Update CHANGELOG and history * Use <a> color for blockquote.notice border (mmistakes#3140) Close mmistakes#3068 * Update CHANGELOG and history * Fix inline code style not applied to stylized text (mmistakes#3253) * bug: inline code style not applied to stylized text * Use double colons for pseudoelements * Update CHANGELOG and history * Update to Jquery 3.6.0 (mmistakes#3254) * Update CHANGELOG and history * fix typo about loading javascript in footer (mmistakes#3350) * Update CHANGELOG and history * add optinal lunr searching of pages (mmistakes#3352) * Update CHANGELOG and history * Exclude `main.scss` from Lunr search index * Add Kiswahili translation (mmistakes#3489) * Add Kiswahili translation * Add Kiswahli to README * Add Kiswahili to documentation * Update * Update attribution link (mmistakes#3553) * Update CHANGELOG and history * Update link to Font Awesome gallery (mmistakes#3599) * Update CHANGELOG and history * Make it possible to enable breadcrumbs per page (mmistakes#3096) * Make it possible to disable breadcrumbs per page * Update single.html * Update single.html * Update algolia-search-scripts.html (mmistakes#3102) Fix issue mmistakes#3101 * Update CHANGELOG and history * Replace with public YouTube video Close mmistakes#3649 * Replace with public YouTube video embeds * Update CHANGELOG and history * Fix mmistakes#3096 enabling breadcrumb on all pages (mmistakes#3668) * Remove IE9 upgrade notice (mmistakes#3666) * Update CHANGELOG and history * Fix mmistakes#3668 breaking "disable per-page when globally enabled" (mmistakes#3669) * Fix mmistakes#3668 breaking "disable per-page when globally enabled" * `default:` filter doesn't fit here https://shopify.github.io/liquid/filters/default/ * Update CHANGELOG and history * Improve PR close auto-comment message (mmistakes#3713) * Improve auto-comment message * Lock these PRs after closing * add webrick * whatever, line ending perhaps * bug fix --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: iBug ♦ <[email protected]> Co-authored-by: dianlujitao <[email protected]> Co-authored-by: Michael Rose <[email protected]> Co-authored-by: 谭九鼎 <[email protected]> Co-authored-by: Juan Ara <[email protected]> Co-authored-by: Michael Rose <[email protected]> Co-authored-by: Andrey Kartashov <[email protected]> Co-authored-by: Lim Jing Heng <[email protected]> Co-authored-by: Miguel Belardinelli Prytoluk <[email protected]> Co-authored-by: Johannes Ganzenmüller <[email protected]> Co-authored-by: Lars Olesen <[email protected]> Co-authored-by: Leo <[email protected]> Co-authored-by: Kai A <[email protected]> Co-authored-by: Quan <[email protected]> Co-authored-by: M. Akhyar Rahman H <[email protected]> Co-authored-by: Mitchell Skaggs <[email protected]> Co-authored-by: Susan Stevens <[email protected]> Co-authored-by: Jip-Hop <[email protected]> Co-authored-by: gricn <[email protected]> Co-authored-by: Uri Brecher <[email protected]> Co-authored-by: PHOENiX <[email protected]> Co-authored-by: Sean Killeen <[email protected]> Co-authored-by: Johannes Ganzenmüller <[email protected]> Co-authored-by: Nicolas Elie <[email protected]> Co-authored-by: luweizheng <[email protected]> Co-authored-by: Vincent Tam <[email protected]> Co-authored-by: Tom Manner <[email protected]> Co-authored-by: Tom Manner <[email protected]> Co-authored-by: ShifraSec <[email protected]> Co-authored-by: David Lechner <[email protected]> Co-authored-by: Randall Wood <[email protected]> Co-authored-by: Guillaume Gautreau <[email protected]> Co-authored-by: Christian Oliff <[email protected]> Co-authored-by: Erik Westrup <[email protected]> Co-authored-by: Anton Brall <[email protected]> Co-authored-by: Kulbhushan Chand <[email protected]> Co-authored-by: Peter Murray <[email protected]> Co-authored-by: Johnson <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: John Scott <[email protected]> Co-authored-by: Nathan Cho <[email protected]> Co-authored-by: Jason Hemann <[email protected]> Co-authored-by: Daniel Schroeder <[email protected]> Co-authored-by: Georger Araújo <[email protected]> Co-authored-by: Andrew McIntosh <[email protected]> Co-authored-by: Sander Holvoet <[email protected]> Co-authored-by: Yuchen <[email protected]> Co-authored-by: Yuchen Zhong <[email protected]> Co-authored-by: Nicholas Perry <[email protected]> Co-authored-by: Benson Muite <[email protected]> Co-authored-by: FavorMylikes <[email protected]>

SeanKilleen added 15 commits June 26, 2021 10:52

Add script in same style as utterances

a7534a6

But adjusted for the various filed differences

Add initial script

c9330c7

Add default settings

b0d5b1e

Update changelog

3348c57

Add feature to readme

31b83b9

Add comments html

c6bccbd

add comment provider include

f8844d7

update config in docs

481f36f

Add URL for additional reference

c25025e

docs for giscus comments

2108f6b

Unrelated bugfix: add missing version separator

55d925a

So that things match the "history" doc.

add space

e6a042e

update history doc

2dae4a9

update about doc

50874cf

add to test config yaml

80c1db4

SeanKilleen mentioned this pull request Jun 26, 2021

Move away from Disqus SeanKilleen/seankilleen.github.io#577

Closed

5 tasks

SeanKilleen added 2 commits June 26, 2021 12:49

remove unnecessary / incorrect async attribute

5e8f92d

probably should pass the right config paths

655abdd

lowercase the repo name

5a04d58

SeanKilleen changed the title ~~WIP: Add giscus support~~ Add giscus support Jun 27, 2021

SeanKilleen commented Jun 27, 2021

View reviewed changes

SeanKilleen mentioned this pull request Jun 27, 2021

Giscus fails when repository contains capitals giscus/giscus#118

Closed

Update docs to address '1' and '0' for reactions_enabled

5fe9ae0

Figured I'd match the giscus format rather than convert a boolean to an int there.

update two additional docs

807c816

mmistakes added Status: Review Needed Type: Enhancement labels Jun 27, 2021

mmistakes reviewed Jul 5, 2021

View reviewed changes

mmistakes requested changes Jul 5, 2021

View reviewed changes

docs wording fix

0a7b730

mmistakes added Status: Accepted and removed Status: Review Needed labels Jul 5, 2021

mmistakes approved these changes Jul 5, 2021

View reviewed changes

mmistakes merged commit 297989c into mmistakes:master Jul 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add giscus support #3022

Add giscus support #3022

SeanKilleen commented Jun 26, 2021 •

edited

Loading

SeanKilleen commented Jun 26, 2021

SeanKilleen commented Jun 26, 2021

mmistakes commented Jun 26, 2021

SeanKilleen commented Jun 26, 2021

SeanKilleen commented Jun 26, 2021

SeanKilleen commented Jun 27, 2021

SeanKilleen commented Jun 27, 2021

SeanKilleen Jun 27, 2021

SeanKilleen commented Jun 29, 2021 •

edited

Loading

mmistakes Jul 5, 2021

mmistakes left a comment

SeanKilleen commented Jul 5, 2021

SeanKilleen commented Jul 5, 2021


		To use giscus you will need to [install the app](https://github.com/apps/giscus) to your GitHub repository.

		The next step is to go to <https://giscus.app> and fill out the desired settings. This will generate a javascript, which will provide you with some of the settings you will need to configure things below.

Add giscus support #3022

Add giscus support #3022

Conversation

SeanKilleen commented Jun 26, 2021 • edited Loading

Summary

Context

How to Test

SeanKilleen commented Jun 26, 2021

SeanKilleen commented Jun 26, 2021

mmistakes commented Jun 26, 2021

SeanKilleen commented Jun 26, 2021

SeanKilleen commented Jun 26, 2021

SeanKilleen commented Jun 27, 2021

SeanKilleen commented Jun 27, 2021

SeanKilleen Jun 27, 2021

Choose a reason for hiding this comment

SeanKilleen commented Jun 29, 2021 • edited Loading

mmistakes Jul 5, 2021

Choose a reason for hiding this comment

mmistakes left a comment

Choose a reason for hiding this comment

SeanKilleen commented Jul 5, 2021

SeanKilleen commented Jul 5, 2021

SeanKilleen commented Jun 26, 2021 •

edited

Loading

SeanKilleen commented Jun 29, 2021 •

edited

Loading