Add MSVC build #9740
Add MSVC build #9740
Conversation
nerzhul
added
@ Build
.github/workflows/build.yml
Outdated
| generator: "-G'Visual Studio 16 2019' -A x64", | ||
| vcpkg_triplet: x64-windows | ||
| } | ||
| type: [portable, installer] |
There was a problem hiding this comment.
portable is pretty much guaranteed to work, it's enough if these jobs test only the installer
There was a problem hiding this comment.
Someone still have to do it. If there is a change, that cant be tested by simply compiling it, users have to either compile the changes by themself or they can now just download the package and and try it without the need of compiling.
It runs parallel, its already implemented, why not use it?
There was a problem hiding this comment.
Someone still have to do it.
The Gitlab pipeline already tests ZIP package generation.
If there is a change, that cant be tested by simply compiling it, users have to either compile the changes by themself or they can now just download the package and and try it without the need of compiling.
I am not saying artifacts should be removed.
It runs parallel, its already implemented, why not use it?
I don't really like have the CI waste time even if it's "free".
There was a problem hiding this comment.
remember that we can run 10 jobs in parallel in the free version here, but we may just run this on master, it's less runs that on each pull request, and is more reasonable no ? :)
There was a problem hiding this comment.
There's only 10 jobs in parallel? Then this definitely does make a difference.
There was a problem hiding this comment.
oh yeah it's 20, we are fine then
Yeah skip the
installervariant then.
😂 Keep it as its currently is, or skip the installer?
There was a problem hiding this comment.
I still propose having just portable builds since that fulfills both the "test compiling with MSVC" and "produce usable artifact".
There was a problem hiding this comment.
Can you produce installer builds on tagged commits?
There was a problem hiding this comment.
Can you produce installer builds on tagged commits?
could be possible https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif But it depends on how does the if work in combination with the matrix
There was a problem hiding this comment.
Can you produce installer builds on tagged commits?
could be possible https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif But it depends on how does the if work in combination with the matrix
Sadly it isn't possible yet https://github.community/t5/GitHub-Actions/Matrix-cannot-be-used-in-jobs-level-if/td-p/41048
I would suggest to create a build-release.yml that is doing the full job (including minetest game) if a tag is pushed. But I think that will be better done in a separate PR
I currently disabled the installer builds. If someone is working on the installer he can simply enable them.
|
I don't know if Github's documentation is wrong or whatever, but here you can see 10 jobs running and one waiting to be ran. This implies there are not 20 but 10 concurrent jobs. |
|
|
|
merged, thanks for your time. Maybe someone can provide a macosx one after that ? (don't know if we have mac osx users yet) |
This adds MSVC builds to GitHub actions including x86, x64, portable and installer
To do
This PR is Ready for Review.
How to test
Wait until build completes, go to Actions download artifact and try it.