Drop useless -Wabi flag #9676
Merged
Drop useless -Wabi flag #9676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerzhul
added
@ Build
sfan5
reviewed
Apr 15, 2020
nerzhul
force-pushed
the
fix/gcc_warning_abi
branch
2 times, most recently
from
c33d0e5
to
21849f3
Compare
|
good or not good ? what i need to do @sfan5 ? |
|
My confusion here is whether we need |
nerzhul
force-pushed
the
fix/gcc_warning_abi
branch
from
21849f3
to
54ef285
Compare
sfan5
approved these changes
Apr 16, 2020
aldum
pushed a commit
to banyamesterseg/minetest
that referenced
this pull request
Apr 16, 2020
nerzhul
added a commit
to nerzhul/minetest
that referenced
this pull request
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent GCC warn about the abi flag incorrectly used.
Fix the flag for GCC, keep the original behaviour for the others
fixes #9433
To do
This PR is Ready for Review.
How to test
Build with recent gcc, no warning about abi, build with clang, no warning about flag too