Optimize get_objects_inside_radius calls #9671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerzhul
force-pushed
the
feature/lightweight_get_object_inside_radius
branch
5 times, most recently
from
5056d22
to
3230965
Compare
sfan5
reviewed
Apr 14, 2020
our previous implementation calls the ActiveObjectMgr to return ids and then lookup those ids in the same map and test each object Instead now we call the global map to return the pointers directly and we ask filtering when building the list using lamba. This drop double looping over ranges of active objects (and then filtered one) and drop x lookups on the map regarding the first call results
nerzhul
force-pushed
the
feature/lightweight_get_object_inside_radius
branch
from
3230965
to
ccf46ef
Compare
|
Found fitting test mod (N° 02/65): #6803 (comment)
Addition in the linked test mod:
Test command: PR + profiler: 82us (8.2e-5) |
sfan5
reviewed
Apr 15, 2020
sfan5
changed the title
sfan5
approved these changes
Apr 15, 2020
thanks for the tests @SmallJoker |
nerzhul
force-pushed
the
feature/lightweight_get_object_inside_radius
branch
from
d876167
to
023d407
Compare
aldum
pushed a commit
to banyamesterseg/minetest
that referenced
this pull request
Apr 16, 2020
* Optimize getObjectsInsideRadius calls our previous implementation calls the ActiveObjectMgr to return ids and then lookup those ids in the same map and test each object Instead now we call the global map to return the pointers directly and we ask filtering when building the list using lamba. This drop double looping over ranges of active objects (and then filtered one) and drop x lookups on the map regarding the first call results
nerzhul
added a commit
to nerzhul/minetest
that referenced
this pull request
Apr 27, 2020
* Optimize getObjectsInsideRadius calls our previous implementation calls the ActiveObjectMgr to return ids and then lookup those ids in the same map and test each object Instead now we call the global map to return the pointers directly and we ask filtering when building the list using lamba. This drop double looping over ranges of active objects (and then filtered one) and drop x lookups on the map regarding the first call results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our previous implementation calls the ActiveObjectMgr to return ids and then lookup those ids in the same map and test each object
Instead now we call the global map to return the pointers directly and we ask filtering when building the list using lamba.
This drop double looping over ranges of active objects (and then filtered one) and drop x lookups on the map regarding the first call results
To do
This PR is a Ready for Review.
How to test
Have item_drops and a mob framework with mobs and just see it works (a little bit better)