-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace travis with github actions #9641
Conversation
901bb5d
to
0f2d00d
Compare
travis is totally broken currently... Nice haha |
I don't think there's a pressing need to move to Github actions, having all checks on a single platform is quite nice. On the other hand travis is quite slow sometimes and this can speed it up. I'm neutral to this. Would be nice to hear other coredevs opinion on this. |
6a9fd09
to
12d0835
Compare
67e13cc
to
02afe53
Compare
@nerzhul Interesting, what about integration-tests to verify that the final build actually runs?
Also here for my custom minetest build:
This spins up the built binary and does some (currently stupid) sanity checks on that.. |
It will be the same as before currently, i just want to have iso builds, but after we can have PR to improve that. Don't forget that gitlab does the artifact build |
3c00ee3
to
4761f5f
Compare
0162d83
to
c25314d
Compare
This will permit to have better integrated CI workflow than the previous travis one.
c25314d
to
0e5820a
Compare
@sfan5 your turn |
Co-Authored-By: sfan5 <[email protected]>
Co-Authored-By: sfan5 <[email protected]>
17e16ff
to
6dd06ea
Compare
0ee9ea9
to
0f439bb
Compare
0f439bb
to
ec01022
Compare
* Move outside of travis to Github actions This will permit to have better integrated CI workflow than the previous travis one.
Travis is quite old, slow and unfriendly to maintain. Use the new github
actions for some of our checks instead of travis.
This speeds up the build, github infra is faster, and also maintained, unlike travis old runners :(
This should permit in the future to restore the Mac OSX build and maybe windows native builds
To do
This PR is a Ready for Review but there is a missing build
How to test
Just look at the ci ?