Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace travis with github actions #9641

Merged
merged 9 commits into from
Apr 20, 2020

Conversation

nerzhul
Copy link
Member

@nerzhul nerzhul commented Apr 11, 2020

Travis is quite old, slow and unfriendly to maintain. Use the new github
actions for some of our checks instead of travis.

This speeds up the build, github infra is faster, and also maintained, unlike travis old runners :(

This should permit in the future to restore the Mac OSX build and maybe windows native builds

To do

This PR is a Ready for Review but there is a missing build

  • Windows binary builds

How to test

Just look at the ci ?

@nerzhul nerzhul force-pushed the feature/github_lint_actions branch from 901bb5d to 0f2d00d Compare April 11, 2020 10:50
@nerzhul
Copy link
Member Author

nerzhul commented Apr 11, 2020

travis is totally broken currently... Nice haha

@sfan5
Copy link
Member

sfan5 commented Apr 11, 2020

I don't think there's a pressing need to move to Github actions, having all checks on a single platform is quite nice. On the other hand travis is quite slow sometimes and this can speed it up.

I'm neutral to this. Would be nice to hear other coredevs opinion on this.

@sfan5 sfan5 added @ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements labels Apr 11, 2020
@nerzhul nerzhul changed the title Move luacheck to github actions Move luacheck & clang-tidy to github actions Apr 11, 2020
@nerzhul nerzhul marked this pull request as draft April 11, 2020 11:25
@nerzhul nerzhul force-pushed the feature/github_lint_actions branch 7 times, most recently from 6a9fd09 to 12d0835 Compare April 11, 2020 11:48
@nerzhul nerzhul changed the title Move luacheck & clang-tidy to github actions Move luacheck & clang-{tidy,format} to github actions Apr 11, 2020
@nerzhul nerzhul force-pushed the feature/github_lint_actions branch 9 times, most recently from 67e13cc to 02afe53 Compare April 11, 2020 14:13
@BuckarooBanzay
Copy link
Contributor

@nerzhul Interesting, what about integration-tests to verify that the final build actually runs?
I'm using this pattern for quite a while in my mods and tools now:

Also here for my custom minetest build:

This spins up the built binary and does some (currently stupid) sanity checks on that..
You could even test mapgen related functions (https://github.com/mt-mods/jumpdrive/blob/master/integration_test.lua)

@nerzhul
Copy link
Member Author

nerzhul commented Apr 16, 2020

It will be the same as before currently, i just want to have iso builds, but after we can have PR to improve that. Don't forget that gitlab does the artifact build

@nerzhul nerzhul force-pushed the feature/github_lint_actions branch 2 times, most recently from 3c00ee3 to 4761f5f Compare April 19, 2020 08:03
@nerzhul nerzhul marked this pull request as ready for review April 19, 2020 08:03
@nerzhul nerzhul requested a review from sfan5 April 20, 2020 07:20
@nerzhul nerzhul force-pushed the feature/github_lint_actions branch from 0162d83 to c25314d Compare April 20, 2020 07:29
This will permit to have better integrated CI workflow than the previous
travis one.
@nerzhul nerzhul force-pushed the feature/github_lint_actions branch from c25314d to 0e5820a Compare April 20, 2020 07:31
@nerzhul
Copy link
Member Author

nerzhul commented Apr 20, 2020

@sfan5 your turn

@nerzhul nerzhul closed this Apr 20, 2020
@sfan5 sfan5 reopened this Apr 20, 2020
.gitlab-ci.yml Outdated Show resolved Hide resolved
util/ci/build.sh Outdated Show resolved Hide resolved
util/ci/common.sh Outdated Show resolved Hide resolved
util/ci/clang-tidy.sh Outdated Show resolved Hide resolved
@nerzhul nerzhul force-pushed the feature/github_lint_actions branch from 17e16ff to 6dd06ea Compare April 20, 2020 15:57
@nerzhul nerzhul requested a review from sfan5 April 20, 2020 16:10
@nerzhul nerzhul force-pushed the feature/github_lint_actions branch 2 times, most recently from 0ee9ea9 to 0f439bb Compare April 20, 2020 17:45
@nerzhul nerzhul force-pushed the feature/github_lint_actions branch from 0f439bb to ec01022 Compare April 20, 2020 17:47
@nerzhul nerzhul merged commit 27a485a into minetest:master Apr 20, 2020
@nerzhul nerzhul deleted the feature/github_lint_actions branch April 20, 2020 18:18
nerzhul added a commit to nerzhul/minetest that referenced this pull request Apr 27, 2020
* Move outside of travis to Github actions

This will permit to have better integrated CI workflow than the previous
travis one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants