Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find PostgreSQL correctly #8435

Merged
merged 1 commit into from
Apr 7, 2019
Merged

Conversation

adrido
Copy link
Contributor

@adrido adrido commented Mar 31, 2019

@nerzhul , You implemented the original part, please review. Thanks.
ce42ff9

As there might be questions:
See https://cmake.org/cmake/help/v3.14/module/FindPostgreSQL.html

The bulk to get an PostgreSQL_ADDITIONAL_SEARCH_PATHS did not work correctly the whole years, so I consider it as not needed.

This makes PostgereSQL usable on Windows too

@sfan5 sfan5 requested a review from nerzhul March 31, 2019 13:55
@nerzhul nerzhul changed the title Find PostgereSQL correctly Find PostgreSQL correctly Mar 31, 2019
@nerzhul nerzhul added @ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️ labels Mar 31, 2019
@adrido
Copy link
Contributor Author

adrido commented Apr 2, 2019

Just fixed a typo in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants