Make FindCURL ready for vcpkg #8295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to find and use curl with the vcpkg toolchain file.
SmallJoker
reviewed
Apr 14, 2019
SmallJoker
approved these changes
Apr 18, 2019
0e3b135
to
39c54e1
Compare
|
👍 |
|
0 changed files... |
|
Sorry, my fault. Should have closed this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to find and use curl with the vcpkg toolchain file.
There will be another PR regarding vcpkg on Windows, but this is kind of urgent: Never ever copy a file out of the Windows directory and redistribute them!
That might not work from technical aspects (x32 vs x64), it is also very questionable in terms of license.
Last but not least: This also allows to build Minetest on windows with a static linked version of curl.