Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise hotbar limit to 32 slots, add associated keybinding options #7916

Merged
merged 3 commits into from
Dec 2, 2018
Merged

raise hotbar limit to 32 slots, add associated keybinding options #7916

merged 3 commits into from
Dec 2, 2018

Conversation

VanessaE
Copy link
Contributor

@VanessaE VanessaE commented Dec 1, 2018 •
edited by paramat
Loading

Closes #7915

@VanessaE
raise hotbar limit to 32 slots
35b2c4d 
add associated keybinding options
@VanessaE VanessaE mentioned this pull request Dec 1, 2018
Closed
@paramat
Copy link
Contributor

paramat commented Dec 1, 2018

I support raising the limit to 32, even if not enough keys exist to bind them all.
Not for 0.4.x though, it's not a bugfix, and i know you're trying to resist moving to 5.0.0. The more attractive 5.0.0 is the better.

@paramat paramat added @ Client / Audiovisuals Feature ✨ PRs that add or enhance a feature labels Dec 1, 2018
@ClobberXD
Copy link
Contributor

ClobberXD commented Dec 1, 2018 •
edited
Loading

lua_api.txt needs to be updated here:

minetest/doc/lua_api.txt

Lines 5188 to 5189 in dcf58a3

* `hud_set_hotbar_itemcount(count)`: sets number of items in builtin hotbar
* `count`: number of items, must be between `1` and `23`

@VanessaE
update docs and settingtypes
2ef1a27 
(also fix a few related, obvious copy&paste errors, 1th -> 1st, etc)
@VanessaE
Copy link
Contributor Author

VanessaE commented Dec 1, 2018

Fixed docs and settingtypes.txt.

SmallJoker
SmallJoker reviewed Dec 2, 2018
View reviewed changes
src/client/game.cpp Outdated Show resolved Hide resolved
SmallJoker
SmallJoker approved these changes Dec 2, 2018
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@sfan5 sfan5 merged commit 1b0fd19 into minetest:master Dec 2, 2018
Wuzzy2 pushed a commit to Wuzzy2/minetest that referenced this pull request Dec 11, 2018
@VanessaE @Wuzzy2
Raise hotbar limit to 32 slots, add associated keybinding options (mi…
b978d7b 
…netest#7916)

add associated keybinding options
update docs and settingtypes
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
@VanessaE @osjc
Raise hotbar limit to 32 slots, add associated keybinding options (mi…
f01e165 
…netest#7916)

add associated keybinding options
update docs and settingtypes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

@SmallJoker SmallJoker SmallJoker approved these changes

@ClobberXD ClobberXD ClobberXD approved these changes

Assignees
No one assigned
Labels
@ Client / Audiovisuals Feature ✨ PRs that add or enhance a feature >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@VanessaE @paramat @ClobberXD @sfan5 @SmallJoker