Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy chat network code. #6954

Merged
merged 1 commit into from
Feb 17, 2018
Merged

Remove legacy chat network code. #6954

merged 1 commit into from
Feb 17, 2018

Conversation

red-001
Copy link
Contributor

@red-001 red-001 commented Jan 23, 2018

No description provided.

@SmallJoker
Copy link
Member

@nerzhul requested to keep the // Obsolete enum entries in the last cleanup PR: #6404 (comment)

@SmallJoker SmallJoker added the Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements label Jan 23, 2018
@red-001
Copy link
Contributor Author

red-001 commented Jan 23, 2018

Not sure how useful documenting that is if we are dropping compatibility.

@nerzhul
Copy link
Member

nerzhul commented Jan 23, 2018

yeah i prefer keep the current obsolete enum to remember some old behaviour, keeping them commented should do the trick :)

@red-001
Copy link
Contributor Author

red-001 commented Jan 23, 2018

@nerzhul maybe just document it in a comment at the top of the file?

@sfan5
Copy link
Member

sfan5 commented Jan 23, 2018

Keeping them commented out or in a big comment at the top is useless.
If you want to keep them, just keep them inline with the // Obsolete hint.

@nerzhul
Copy link
Member

nerzhul commented Jan 23, 2018

then just remove the obsolete function, move it to deprecated handler ?

@red-001 red-001 changed the title Remove unused packet IDs and network code. Remove legacy chat network code. Jan 23, 2018
SmallJoker
SmallJoker approved these changes Feb 15, 2018
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Possible squashed commit message: Remove legacy ChatMessageOld handler

@nerzhul nerzhul merged commit ae6aed1 into minetest:master Feb 17, 2018
@red-001 red-001 deleted the clean_obsolete branch February 17, 2018 19:54
minduser00 pushed a commit to minduser00/minetest that referenced this pull request Mar 18, 2018
@red-001 @minduser00
Remove legacy chat network code. (minetest#6954)
c8ee980
minduser00 pushed a commit to minduser00/minetest that referenced this pull request Mar 18, 2018
@red-001 @minduser00
Remove legacy chat network code. (minetest#6954)
9db107c
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 11, 2019
@red-001 @osjc
Remove legacy chat network code. (minetest#6954)
633e107
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
@red-001 @osjc
Remove legacy chat network code. (minetest#6954)
4be9a6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerzhul nerzhul nerzhul approved these changes

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@red-001 @SmallJoker @nerzhul @sfan5