-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move files to subdirectories #6599
Conversation
src/gui/CMakeLists.txt
Outdated
${CMAKE_CURRENT_SOURCE_DIR}/guiTable.cpp | ||
${CMAKE_CURRENT_SOURCE_DIR}/guiVolumeChange.cpp | ||
${CMAKE_CURRENT_SOURCE_DIR}/intlGUIEditBox.cpp | ||
${CMAKE_CURRENT_SOURCE_DIR}/touchscreengui.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be compiled for non-android
also note that you need to update build/android/jni/Android.mk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is “this” touchscreengui.cpp
? I just noticed that it doesn’t compile at all. So I removed it from the list.
But note that some x86 devices (like my laptop) have touchscreens as well, so that should not be Android-specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so that should not be Android-specific.
in theory yes
in practice the desktop "version" of irrlicht does not support touch events at all (which is why it won't build)
OK? |
yes 👍 |
Will this break Github 'history' and 'blame' for these files? Both are extremely useful for dev work. |
But not history unfortunately. |
i approve that change too, time to have a clear thing, not C crap folder :p |
yay! We should also start moving unprefixed files to good directories |
of course :) |
* Move files around
* Move files around
* Move files around
No description provided.