Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move files to subdirectories #6599

Merged
merged 5 commits into from
Nov 8, 2017
Merged

Move files to subdirectories #6599

merged 5 commits into from
Nov 8, 2017

Conversation

numberZero
Copy link
Contributor

No description provided.

@numberZero numberZero changed the title Move files to subdirectories [WIP] Move files to subdirectories Nov 7, 2017
${CMAKE_CURRENT_SOURCE_DIR}/guiTable.cpp
${CMAKE_CURRENT_SOURCE_DIR}/guiVolumeChange.cpp
${CMAKE_CURRENT_SOURCE_DIR}/intlGUIEditBox.cpp
${CMAKE_CURRENT_SOURCE_DIR}/touchscreengui.cpp
Copy link
Member

@sfan5 sfan5 Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be compiled for non-android
also note that you need to update build/android/jni/Android.mk

Copy link
Contributor Author

@numberZero numberZero Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is “this” touchscreengui.cpp? I just noticed that it doesn’t compile at all. So I removed it from the list.
But note that some x86 devices (like my laptop) have touchscreens as well, so that should not be Android-specific.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so that should not be Android-specific.

in theory yes
in practice the desktop "version" of irrlicht does not support touch events at all (which is why it won't build)

@sfan5 sfan5 added the Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements label Nov 7, 2017
@numberZero numberZero changed the title [WIP] Move files to subdirectories Move files to subdirectories Nov 7, 2017
@numberZero
Copy link
Contributor Author

OK?

@sfan5
Copy link
Member

sfan5 commented Nov 7, 2017

yes 👍

@paramat
Copy link
Contributor

paramat commented Nov 8, 2017

Will this break Github 'history' and 'blame' for these files? Both are extremely useful for dev work.

@sfan5
Copy link
Member

sfan5 commented Nov 8, 2017

@paramat
Copy link
Contributor

paramat commented Nov 8, 2017

But not history unfortunately.
But then, history can be tracked starting from the file just before the reorganisation.
I'm neutral then.
The reorganisation of mapgen files looks fine to me.

@nerzhul
Copy link
Member

nerzhul commented Nov 8, 2017

i approve that change too, time to have a clear thing, not C crap folder :p

@nerzhul nerzhul merged commit 20a85d7 into minetest:master Nov 8, 2017
@rubenwardy
Copy link
Member

yay! We should also start moving unprefixed files to good directories

@nerzhul
Copy link
Member

nerzhul commented Nov 8, 2017

of course :)

t0ny2 pushed a commit to t0ny2/minetest that referenced this pull request Jan 23, 2018
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 11, 2019
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants