Initial Haiku support #6568
Merged
Initial Haiku support #6568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenwardy
approved these changes
Oct 29, 2017
rubenwardy
added
@ Build
sfan5
reviewed
Oct 29, 2017
src/CMakeLists.txt
Outdated
| @@ -329,9 +337,11 @@ else() | |||
| endif(APPLE) | |||
|
|
|||
| # This way Xxf86vm is found on OpenBSD too | |||
There was a problem hiding this comment.
this comment should be moved inside the if() too
sfan5
reviewed
Oct 29, 2017
src/CMakeLists.txt
Outdated
| if(NOT HAIKU) | ||
| # This way Xxf86vm is found on OpenBSD too |
There was a problem hiding this comment.
now you just need to indent it ;)
sfan5
reviewed
Oct 29, 2017
src/client/renderingengine.cpp
Outdated
| @@ -34,7 +34,8 @@ with this program; if not, write to the Free Software Foundation, Inc., | |||
| #include "inputhandler.h" | |||
| #include "gettext.h" | |||
|
|
|||
| #if !defined(_WIN32) && !defined(__APPLE__) && !defined(__ANDROID__) && !defined(SERVER) && !defined(__HAIKU__) | |||
| #if !defined(_WIN32) && !defined(__APPLE__) && !defined(__ANDROID__) \ | |||
| && !defined(SERVER) && !defined(__HAIKU__) | |||
There was a problem hiding this comment.
the tab in the middle should be a space
|
should we support a such OS ? |
|
@nerzhul should not, but why not to try. |
|
the linter still has a complaint about your syntax: https://travis-ci.org/minetest/minetest/jobs/294459402#L504 |
Not officially support, ie: no builds or ci tests maintained by us, but this pr is fine |
sfan5
reviewed
Oct 29, 2017
src/client/renderingengine.cpp
Outdated
| @@ -34,8 +34,8 @@ with this program; if not, write to the Free Software Foundation, Inc., | |||
| #include "inputhandler.h" | |||
| #include "gettext.h" | |||
|
|
|||
| #if !defined(_WIN32) && !defined(__APPLE__) && !defined(__ANDROID__) \ | |||
| && !defined(SERVER) && !defined(__HAIKU__) | |||
| #if !defined(_WIN32) && !defined(__APPLE__) && !defined(__ANDROID__) && | |||
sfan5
approved these changes
Oct 29, 2017
t0ny2
pushed a commit
to t0ny2/minetest
that referenced
this pull request
Jan 23, 2018
* Iitial Haiku support
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 11, 2019
* Iitial Haiku support
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
* Iitial Haiku support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.