Cpp11 initializers 2 #5999
Merged
Cpp11 initializers 2 #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Drop obsolete bool MainMenuData::enable_public (setting is called with cURL in server loop)
nerzhul
added
the
Maintenance
nerzhul
force-pushed
the
cpp11_initializers_2
branch
from
f054cec
to
01118f8
Compare
SmallJoker
reviewed
Jun 17, 2017
src/guiChatConsole.cpp
Outdated
| } | ||
| else | ||
| { | ||
| else { |
There was a problem hiding this comment.
if (!m_font) {
} else {
}as soon one part isn't an one-liner.
SmallJoker
reviewed
Jun 17, 2017
src/httpfetch.h
Outdated
|
|
||
| HTTPFetchResult(const HTTPFetchRequest &fetch_request) | ||
| : succeeded(false), timeout(false), response_code(0), data(""), | ||
| caller(fetch_request.caller), request_id(fetch_request.request_id) | ||
| : caller(fetch_request.caller), request_id(fetch_request.request_id) |
SmallJoker
reviewed
Jun 17, 2017
| f32 m_pitch = 0.0f; | ||
| bool camera_barely_in_ceiling = false; | ||
| aabb3f m_collisionbox = aabb3f(-BS * 0.30f, 0.0f, -BS * 0.30f, BS * 0.30f, | ||
| BS * 1.75f, BS * 0.30f); |
There was a problem hiding this comment.
Could you please add the new line an argument earlier, so the X,Y,Z values are grouped nicely
|
Apart from the comments above, LGTM. |
|
ty for review i will fix them soon |
nerzhul
force-pushed
the
cpp11_initializers_2
branch
from
01118f8
to
fc79504
Compare
|
@SmallJoker all points fixed |
SmallJoker
approved these changes
Jun 17, 2017
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 11, 2019
* C++11 patchset 10: continue cleanup on constructors * Drop obsolete bool MainMenuData::enable_public (setting is called with cURL in server loop) * More classes cleanup * More classes cleanup + change NULL tests to boolean tests
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
* C++11 patchset 10: continue cleanup on constructors * Drop obsolete bool MainMenuData::enable_public (setting is called with cURL in server loop) * More classes cleanup * More classes cleanup + change NULL tests to boolean tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue previous work: cleaning up constructors. Also fix some NULL checks on nullptr replaced values to be coherent & portable between NULL & nullptr