C++11 patchset 2: remove util/cpp11.h and util/cpp11_container.h #5821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerzhul
added
the
Maintenance
|
I will rebase this when the other PR will be merged or if i need to do some modifications |
nerzhul
force-pushed
the
cpp11_maps_nullptr
branch
from
8e490d2
to
c8c08cf
Compare
nerzhul
force-pushed
the
cpp11_maps_nullptr
branch
from
c8c08cf
to
c6c5f94
Compare
|
rebased |
SmallJoker
reviewed
Jun 4, 2017
src/face_position_cache.cpp
Outdated
| @@ -21,14 +21,14 @@ with this program; if not, write to the Free Software Foundation, Inc., | |||
| #include "threading/mutex_auto_lock.h" | |||
|
|
|||
|
|
|||
| UNORDERED_MAP<u16, std::vector<v3s16> > FacePositionCache::cache; | |||
| std::unordered_map<u16, std::vector<v3s16> > FacePositionCache::cache; | |||
There was a problem hiding this comment.
Either
namespace::container<typename, namespace::container<typename>> or
namespace::container<typename, namespace::container<typename> >
You mixed both notations in this PR.
EDIT: Especially in content_sao.cpp
|
Exact, well done, i will fix it this evening. On c++11 the space isn't required
|
nerzhul
force-pushed
the
cpp11_maps_nullptr
branch
from
c6c5f94
to
c94425a
Compare
SmallJoker
approved these changes
Jun 4, 2017
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 11, 2019
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #5814 to be merged, to review just look at third commit
some long types on unordered_set/map have now typedefs to reduce coding lines