Fix broken default sneak keybind on macOS with SDL #14754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grorp
added
@ Startup / Config / Util
macOS
Bugfix 🐛
sfan5
reviewed
Jun 14, 2024
|
with -DUSE_SDL2=TRUE fonts larger than normal, but not as smooth as with the high dpi patch l-shift works as expected for sneak/fly down l-shift does not work to start typing commands (shift-7 on German keyboard) |
Thank you. That's what I expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(not tested)
To do
This PR is a Ready for Review.
How to test
Build Minetest on macOS.
Verify that sneaking still works by default when built with
-DUSE_SDL2=FALSE.Verify that sneaking now also works by default when built with
-DUSE_SDL2=TRUE.