Disallow formspec debug if the player does not have the debug privilege #14753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zughy
added
Feature ✨
sfan5
reviewed
Jun 15, 2024
|
Whenever the debug privilege gets removed, it now tries to disable the debug mode (can't do that when no formspec is open, but that doesn't matter as the debug mode does not persist across different formspecs). |
appgurueu
reviewed
Jun 15, 2024
appgurueu
approved these changes
Jun 16, 2024
There was a problem hiding this comment.
Thank you. Code is simple and to the point. Tested, works:
- Host server, join with another client.
- Grant other client debug. Press F5 while in inventory formspec: works.
- Revoke debug while other client has formspec debug enabled. The yellow debug overlays disappear immediately.
- Try turning it on again: Doesn't work, as expected.
- Re-grant privilege. Now it can be turned on again.
grorp
requested changes
Jun 16, 2024
grorp
added
the
Action / change needed
appgurueu
removed
the
Action / change needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow players that do not have the "debug" privilege from viewing formspec debug info.
It adds a check for the "debug" privilege before toggling the formspec debug view.
Fixes Everybody can see formspec debug #11689
To do
Ready for Review.
How to test
Open the inventory (or any other formspec), press F5 with and without the "debug" privilege.
The debug view should only be toggled with the "debug" privilege.