-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no squash] Split touch controls from UI #14749
base: master
Are you sure you want to change the base?
Conversation
Well, for UI, since Minetest has no TUI, UI implies always GUI. Anyway I'm ok with both. |
Tested latest changes, no regression spotted. edit: today I'll also run it again the mobile phone https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/55520 |
There's one other (G)UI setting. That other setting is called |
All commits after the first one should be squashed IMO, so that we have two commits in the end. |
Tested on the phone, works exactly as expected. Next thing I'm wondering now, is the ability to ask system for landscape mode and lock (as minetest in portrait mode has a squashed not-much-usable controls.. and it probably doesn't make much sense to do it flexible that much). |
Minetest on Android does that, how would we do it on Linux? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested on Android. Needs squashing as mentioned above.
This is the first half of the changes from #14542. Thanks for splitting them into a separate PR.
I don't know what happened to the feature freeze and release plans btw ¯\(ツ)/¯
8883d87
to
e467fa5
Compare
So far I've been told we would need new Wayland extension for that, which make sense. TBD for now. |
@sfan5 what do you think? |
Seems useful but haven't looked at the code closely. |
e467fa5
to
5d209b5
Compare
This needs a brief review and merge. It's a bit breaking over code-base changes, thou I just rebased. |
5d209b5
to
b950fd8
Compare
to avoid confusion between touchscreen-related settings that affect GUIs (formspecs) and touchscreen-related settings that affect the touch controls (TouchControls / formerly TouchScreenGUI)
…ouch_gui touch_gui provide adjustment to the interface, so it's more touch friendly Signed-off-by: David Heidelberg <[email protected]>
b950fd8
to
9093082
Compare
I would rather do that than risk bringing it new regressions just before a release. |
Prepare for touch screen autodetection.
Split touchscreen controls from UI adjustment for touch screen devices.
No. But prepares ground for auto-detection of touch input, where changes in UI would be undesired.
Yes, it does improve touchscreen experience and clarity of the TS code.
How to test
Check the UI settings, check the touchscreen settings.